events/loop: dynamically increase queue size #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the event control loop implementation to dynamically grow the event queue when it reaches capacity. This change allows the loop to handle a larger number of events without blocking Enqueue, removing issues of circular dependencies in certain scenarios. Queues are now split into segments, each with the given fixed size. When the current segments are full, a new segment is allocated and linked to the end of the queue. This allows the queue to grow as needed. Uses `sync.Pool` to reduce allocations for segments. Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
requested changes
Nov 13, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
One tweak I noticed and suggested - great job 🎉
Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the event control loop implementation to dynamically grow the event queue when it reaches capacity. This change allows the loop to handle a larger number of events without blocking Enqueue, removing issues of circular dependencies in certain scenarios.
Queues are now split into segments, each with the given fixed size. When the current segments are full, a new segment is allocated and linked to the end of the queue. This allows the queue to grow as needed. Uses
sync.Poolto reduce allocations for segments.