Fix #14305 Wrong buffer sizes computed by valueFlowDynamicBufferSize() #8006
Conversation
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I do not see why we want to have different results from ValueType::typeSize and ValueFlow::getSizeOf. Can you explain it? Did you consider refactoring so that ValueType::typeSize calls ValueFlow::getSizeOf or vice versa?
Yes, having those two functions is unfortunate, and they should be merged. |
|
BTW, is daca down? I haven't been able to connect to http://cppcheck1.osuosl.org:8000/ for a while. |
The server did not start up because the package index was corrupted. It is fixed now. |
Clients process data again. Had been broken for over a week. |
lib/valueflow.cpp
Outdated
| ValueType vt = *typeTok->valueType(); | ||
| if (vt.pointer > 0) | ||
| --vt.pointer; | ||
| const size_t typeSize = vt.getSizeOf(settings, ValueType::Accuracy::ExactOrZero, ValueType::SizeOf::Pointer); |
There was a problem hiding this comment.
I did not check how this works.. but do we have to create a temporary?
I spontanously wonder; can't the 3rd argument be typeTok->valueType()->pointer > 1 ? ValueType::Sizeof::Pointer : ValueType::SizeOf::Pointee or something like that?
There was a problem hiding this comment.
Yeah, that should no longer be necessary.
|
| "}"; | ||
| values = tokenValues(code, "( D )"); | ||
| ASSERT_EQUALS(1U, values.size()); | ||
| TODO_ASSERT_EQUALS(2 * settings.platform.sizeof_pointer, 1, values.back().intvalue); |
There was a problem hiding this comment.
This was already incorrect before.
4 participants
No description provided.