Fix when hash is inner a value of a variable that escaped by quote #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosure19
force-pushed
the
bugfix/escape-hash-on-quote
branch
from
75a8ae7 to
8212d44
Compare
|
@danday74 Any chance we get this merged ? |
Owner
|
OK the conflict seems fairly easy to resolve and coverage remains at 100% But merging this won't publish it to npm I haven't got time to publish to npm If you give me your npm username then I can add you as a collaborator on npm and you can publish it yourself Let me know if that works for you, if so I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue in case of
MYVAR="anyvalue#anyvalue"will be compute to "anyvalue instead of anyvalue#anyvalue. so we can't escape hash character