use su -s instead of -c for getting interactive shell #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2025
Author
once you finished review of it. i will update the patch at termux |
|
Well, still wrong. It breaks |
| @@ -315,12 +315,13 @@ else | |||
| # Let's use the system toybox/toolbox for now | |||
| if [[ -n "$ENVIRONMENT_PRESERVE" ]]; then | |||
| su_args+=("--preserve-environment") | |||
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Jun 21, 2025
- Closes termux#24820 - Closes termux#18383 - Closes termux#8184 - agnostic-apollo's `sudo` replaces this package: https://github.com/termux/termux-packages/blob/d6015240e4943847544217c924b7fb09bb72a361/packages/sudo/build.sh#L13 - This software is unfortunately not maintained for a while and began to accumulate some issues. The most important issues are already fixed or not present in the `sudo` package. - More information: - termux#24684 - cswl/tsu#116 - termux/termux-app#4612 - topjohnwu/Magisk#9003
loozta8-pixel
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in topjohnwu/Magisk#9003 (comment)