Open
Conversation
Owner
|
hey @CalebM1987 i'm sorry i missed this -- did you wind up forking or can i still merge? |
He fork it in https://github.com/CalebM1987/fernet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposed branch implements this package as a modern es6 module. It uses rollup.js to build the distribution file and also converts it to a commonjs es5 module via babel.
This was created because I could not rollup this module in other modules due to circular dependencies and undefined scopes. This branch offers the following improvements:
rollupresulting in smaller file sizeToken,Secret, etcdocsfolderdefaultsobject to store global configurations forsecret,ttl, andversionHex, while still exporting afernetinstance to scopeTokenstest.htmltoindex.htmland moved intotestfoldertests
All tests are passing in Node, however, I could not get
sinon-chaito work in the test html file andmochacauses memory leaks (possibly because of missingsinon-chai?).