add json encoded debug logging of diff detected instead of GoString to ensure readability#474
Open
larhauga wants to merge 1 commit intocrossplane:mainfrom
Open
add json encoded debug logging of diff detected instead of GoString to ensure readability#474larhauga wants to merge 1 commit intocrossplane:mainfrom
larhauga wants to merge 1 commit intocrossplane:mainfrom
Conversation
mbbush
reviewed
Mar 26, 2025
Contributor
mbbush
left a comment
There was a problem hiding this comment.
This would be a very welcome improvement. Thanks!
Member
|
@larhauga can you update this PR based on the feedback on needing an else clause? |
…o ensure readability Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
Author
Sorry for the delay! Added the else clause now :) |
|
Are there any blockers to have this feature merged? Would be really useful to have when debugging issues related to upjet-based providers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change will provide debug logging in json format instead of go string. This will help when debugging why changes are not affected as this may be the only way you can figure out the different quirks of the cloud provider APIs.
This will remove type information from the output logs, but it will be parsable.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Printed out the new format during test run.