[RFC] conmon: add --timer-command to run command every N seconds#598
[RFC] conmon: add --timer-command to run command every N seconds#598giuseppe wants to merge 1 commit intocontainers:mainfrom
Conversation
|
@jnovy PTAL |
ff930bb to
c0a5300
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
c0a5300 to
38c6cf5
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
38c6cf5 to
7a1b0ec
Compare
|
This will not work for podman, there are normal healthchecks and startup healthchecks which can use a different interval each and only podman knows when to switch. I think this needs some larger design discussion if we would want to do it in conmon. |
|
Concur - without some sort of signaling mechanism to indicate that we are finishing the startup healthcheck and switching to the new parameters, this will not work. Adding that seems like a lot of work for something we're not even sure we want to do (moving HCs into Conmon) |
|
Yes this is not complete implementation, just a couple of hours of work to realize better what is doable and if it is even worth it. Handling different intervals is possible and timers can be unregistered (missing now). Said so, I am still not sure it is worth doing and would leave it as a systemd only feature |
needed for containers/podman#27033