Add support for custom allocators by the allocator-api2 crate. #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds allocator-api2 (a drop-in replacement for the `Allocator` trait on stable) as a dependency. The underlying `Vec` is replaced by `allocator_api2::vec::Vec`, and the type signiture of `VecMap<T>` is changed to `VecMap<T, A: Allocator = Global>`. It adds the methods `new_in()` and `with_capacity_in()` which creates a `VecMap` with a custom allocator. The old `new()` and `with_capacity()` methods are not removed and defaults to the default global allocator. I think that this commit is backwards compatable.
Contributor
|
Hey. That's ok. I will try to pick up maintenance sometime like I did for |
Contributor
|
Huh, have I pushed into your |
Contributor
|
Looks good. Thanks |
pczarn
reviewed
Nov 29, 2024
| } | ||
| } | ||
|
|
||
| impl<V: PartialEq> PartialEq for VecMap<V> { |
Contributor
There was a problem hiding this comment.
What's the story for comparison with regard to allocators?
Author
There was a problem hiding this comment.
After looking at the Vec in the standard library, it seems as that PartialEq and PartialOrd can be implemented for different allocators. I tried and it works so I will make a new pr with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the disclaimer about new contributions in the README, you might think this PR is too much.
However, I needed it for my use case and thought that I can at least share it and then it is up to
you (the maintainer) to decide what to do with it.
This commit adds allocator-api2 (a drop-in replacement for the
Allocatortrait on stable) as a dependency. The underlyingVecisreplaced by
allocator_api2::vec::Vec, and the type signiture ofVecMap<T>is changed toVecMap<T, A: Allocator = Global>.It adds the methods
new_in()andwith_capacity_in()which creates aVecMapwith a custom allocator. The oldnew()andwith_capacity()methods are not removed and defaults to the default global allocator.
I think that this commit is backwards compatable.