[DNM] ChainRpcProvider class with fallback capabilities #509
Conversation
rhlsthrm
left a comment
rhlsthrm
left a comment
There was a problem hiding this comment.
This looks great, nice work.
|
Pending tests. |
jakekidd
force-pushed
the
410-fallback-provider
branch
from
bdf188a to
bc20c0c
Compare
rhlsthrm
left a comment
rhlsthrm
left a comment
There was a problem hiding this comment.
Not fully clear on why we need a custom class yet.
jakekidd
force-pushed
the
410-fallback-provider
branch
from
bd7795e to
927015f
Compare
jakekidd
changed the title
| const hydratedProviders: { [url: string]: ChainRpcProvider } = {}; | ||
| Object.entries(chainProviders).map(([chainId, url]) => { | ||
| hydratedProviders[chainId] = new StaticJsonRpcProvider(url as string, parseInt(chainId)); | ||
| hydratedProviders[chainId] = new ChainRpcProvider(parseInt(chainId), url); |
There was a problem hiding this comment.
Noting that we replaced StaticJsonRpcProvider here - is there something special / different about StaticJsonRpcProvider vs JsonRpcProvider? Do we need to implement additional functionality or a 'Static' version of ChainRpcProvider?
There was a problem hiding this comment.
Hm, we switched to StaticJsonRpcProvider because it cuts down on the number of RPC calls. We should just instantiate as StaticJsonRpcProviders under the hood. Is that possible?
There was a problem hiding this comment.
Yes but lower priority atm
There was a problem hiding this comment.
Do you mean replace JsonRpcProvider with StaticJsonRpcProvider entirely? Or just in this one use case?
There was a problem hiding this comment.
Yes replace entirely. That's what we already did AFAIK.
| import { BigNumber } from "@ethersproject/bignumber"; | ||
| import { JsonRpcProvider, StaticJsonRpcProvider } from "@ethersproject/providers"; | ||
| import { JsonRpcProvider } from "@ethersproject/providers"; | ||
| import { ChainRpcProvider } from "@connext/vector-types"; |
There was a problem hiding this comment.
remove duplicate import
The Problem
Issue #410: #410
The Solution
The user should be able to specify in their router's config multiple provider addresses which can be used to fallback to.
For fallback functionality, we are leaning on ethersproject FallbackProvider, but have made a custom extending class
ChainProviderwhich wraps that functionality but also enforces we are using JsonRpcProvider.Here we've implemented this change with backwards compatability by using comma-separated values. Example for
chainProvidersin config:TODO: Link change in docs where we've updated the config API.