Conversation
…when other columns exist
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the geocoding logic where the presence of all address columns was required, even though the system can construct an address from any subset of available columns. The fix also improves the UI by allowing users to remove previously selected columns that no longer exist in the data source.
Changes:
- Modified address column validation to check for at least one column instead of requiring all columns
- Updated UI to include previously selected columns in the dropdown options for removal
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/server/mapping/geocode.ts | Changed validation logic from requiring all address columns to requiring at least one, enabling geocoding with partial address data |
| src/app/(private)/data-sources/[id]/components/GeocodingConfigFields.tsx | Added logic to merge current column definitions with previously selected columns so users can remove stale column selections |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.