Skip to content

Conversation

@jakubberkop
Copy link

@jakubberkop jakubberkop commented Nov 28, 2025

Work in progress for #2171.
Is this the refactor you have in mind? @robbederks

Building of jungle and body binaries are commented out of now, just to get a poc of the refactor.

@robbederks
Copy link
Contributor

Haven't reviewed in depth, but I think this is roughly in the same direction I'd start. Obviously still needs a lot of work to get the subprojects building and all tests passing again, after that I can give it a closer look.

@jakubberkop jakubberkop force-pushed the source_and_headers branch 4 times, most recently from 2e74d6c to 63dfd6b Compare December 5, 2025 22:46
@jakubberkop
Copy link
Author

jakubberkop commented Dec 5, 2025

Ready for a review. @robbederks

  • I have have suppressed few things in the tests/misra/test_misra.sh, most notably the opendbc includes, as they were causing issues and modifying them seemed out of scope for this task.
  • I also suppressed unused function warnings, for functions that were only used in board/bootstub.c, which is also excluded from the analysis.

@jakubberkop jakubberkop marked this pull request as ready for review December 5, 2025 23:01
@jakubberkop
Copy link
Author

@robbederks please take a look when you have a chance.

@robbederks
Copy link
Contributor

trigger-jenkins

@robbederks
Copy link
Contributor

@jakubberkop: looks like it builds and flashes, but doesn't boot on the panda jungle and thus doesn't try it on the pandas either. do you have any hardware to test this on? does it boot on pandas? If not I can try to debug it too

@jakubberkop
Copy link
Author

@robbederks: Unfortunately no, I don't have any hardware.
I went once again through all of my changes related to panda jungle, and couldn't find anything, so help in debugging it would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants