-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[OPIK-3211] [BE] Replace manual JSON traversal with JSONPath library #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thiagohora
wants to merge
7
commits into
thiago/OPIK-3211-span-level-python-scorer
Choose a base branch
from
thiago/OPIK-3211-jsonpath-filter-evaluation
base: thiago/OPIK-3211-span-level-python-scorer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[OPIK-3211] [BE] Replace manual JSON traversal with JSONPath library #4313
thiagohora
wants to merge
7
commits into
thiago/OPIK-3211-span-level-python-scorer
from
thiago/OPIK-3211-jsonpath-filter-evaluation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace custom navigateJsonPath() method with Jayway JSONPath library - Simplify extractNestedValue() to use JsonPath.read() with configuration - Add JSON_PATH_CONFIG with options for null handling and exception suppression - Remove ~115 lines of manual path parsing code - Maintains backward compatibility with existing path formats - All 110 AutomationRuleEvaluatorsResourceTest tests passing
…OPIK-3211-jsonpath-filter-evaluation
Contributor
…pan Python evaluator - Fix constructor in AutomationRuleEvaluatorSpanUserDefinedMetricPython to match parent signature (filters before code) - Change super.filters to super.getFilters() in both evaluator and update classes - All 110 AutomationRuleEvaluatorsResourceTest tests passing
Contributor
SDK E2E Tests Results0 tests 0 ✅ 0s ⏱️ Results for commit f34aa2d. ♻️ This comment has been updated with latest results. |
…OPIK-3211-jsonpath-filter-evaluation
…OPIK-3211-jsonpath-filter-evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Change checklist
Issues
Testing
NA
Documentation
NA