-
Notifications
You must be signed in to change notification settings - Fork 6
feat: implement tree-shaking #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Dependencies | ||
| node_modules/ | ||
|
|
||
| # Build output | ||
| dist/ | ||
|
|
||
| # Logs | ||
| *.log | ||
|
|
||
| # Test app (internal testing only) | ||
| test-app/ | ||
|
|
||
| # Editor | ||
| .idea/ | ||
| .vscode/ | ||
| *.sw? | ||
|
|
||
| # OS | ||
| .DS_Store | ||
|
|
||
| # Environment | ||
| .env | ||
| .env.local |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| dev/ | ||
| test-app/ | ||
| node_modules/ | ||
| src/ | ||
| *.log | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,9 @@ | |
| <script type="module"> | ||
| import { createApp } from 'vue'; | ||
| import { createRouter, createWebHashHistory } from 'vue-router'; | ||
| import "../src/styles/fonts.pcss"; | ||
| import "../src/styles/index.pcss"; | ||
| import "../src/styles/themes/index.pcss"; | ||
|
Comment on lines
+13
to
+15
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need to update the README as well? |
||
|
|
||
| import Playground from './Playground.vue'; | ||
| import routes from './routes'; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| @import url('../fonts/Inter/inter.css'); | ||
| @import url('../fonts/JetBrainsMono/JetBrainsMono.css'); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| @import url('../fonts/Inter/inter.css'); | ||
| @import url('../fonts/JetBrainsMono/JetBrainsMono.css'); | ||
|
|
||
|
||
| /** | ||
| * Fonts setup | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation doesn't mention that users need to handle font imports separately. Since fonts were moved to a separate fonts.pcss file that is not included in the base styles, users will not have access to the Inter and JetBrains Mono fonts unless they explicitly import them. The README should be updated to document how fonts should be imported, or fonts should be included in the base styles export.