Updated video link in README (marketplace page) #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basit-qc
changed the title
|
Check out the playback for this Pull Request here. |
ZahidSaeed01
approved these changes
Mar 10, 2025
Comment on lines
-135
to
136
| await waitFor(2); | ||
| expect(vscode.window.showInformationMessage).toHaveBeenCalledTimes(1); | ||
| expect(vscode.window.showInformationMessage).toHaveBeenCalledTimes(2); | ||
| expect(vscode.window.showInformationMessage.mock.calls[0][0]).toStrictEqual(NOTIFICATION.LOGGED_OUT_SUCCESSFULLY); |
Contributor
There was a problem hiding this comment.
@Basit-qc, just for my understanding—why did we update this?
Contributor
Author
There was a problem hiding this comment.
Test was failing, not related to this PR. After Logout, we show Welcome Msg to user so there are 2 notifications. Test was asserting 1.
saadberry
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.