Skip to content

Conversation

@Basit-qc
Copy link
Contributor

@Basit-qc Basit-qc commented Jan 16, 2025

Org Selection
image

Team Selection
image

yarn test
image

@Basit-qc Basit-qc requested a review from saadberry January 16, 2025 11:46
@Basit-qc Basit-qc self-assigned this Jan 16, 2025
@github-actions
Copy link

github-actions bot commented Jan 17, 2025

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/yarn' failed with exit code 1
St.
Category Percentage Covered / Total
🟢 Statements
81.72% (-1.18% 🔻)
2642/3233
🟡 Branches
70.26% (-0.24% 🔻)
905/1288
🟢 Functions
80.88% (-2.15% 🔻)
368/455
🟢 Lines
83.99% (-1.25% 🔻)
2492/2967
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / s3_uploader.ts
77.31% 56.41% 96% 83.16%
🟢
... / utils.ts
97.32% 82% 100% 99.05%
🟢
... / connect_repo_handler.ts
88.68% 86.21% 66.67% 88.24%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / api_utils.ts
49.28% (-21.84% 🔻)
56.25% (-18.75% 🔻)
50% (-25% 🔻)
49.28% (-21.84% 🔻)
🔴
... / notifications.ts
33% (-19.46% 🔻)
20.83% (-7.74% 🔻)
35% (-18.85% 🔻)
36.26% (-17.97% 🔻)

Test suite run failed

Failed tests: 3/310. Failed suites: 3/28.
  ● handleRenameFile › For file renamed in sub directory

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      242 |     const renamedShadowFilePath = path.join(shadowRepoBranchPath, newRelPath);
      243 |     // Verify file has been renamed in the shadow repo
    > 244 |     expect(fs.existsSync(oldShadowFilePath)).toBe(false);
          |                                              ^
      245 |     expect(fs.existsSync(renamedShadowFilePath)).toBe(true);
      246 |     // Verify correct diff file has been generated
      247 |     let diffFiles = fs.readdirSync(diffsRepo);

      at toBe (tests/helpers/helpers.js:244:46)
      at Object.<anonymous> (tests/test_events/handler/handleRename.test.js:324:33)


  ● logoutHandler › Verify Logout URL

    expect(jest.fn()).toHaveBeenCalledTimes(expected)

    Expected number of calls: 1
    Received number of calls: 2

      133 |         expect(vscode.commands.executeCommand.mock.calls[0][2]).toBe(true);
      134 |         await waitFor(2);
    > 135 |         expect(vscode.window.showInformationMessage).toHaveBeenCalledTimes(1);
          |                                                      ^
      136 |         expect(vscode.window.showInformationMessage.mock.calls[0][0]).toStrictEqual(NOTIFICATION.LOGGED_OUT_SUCCESSFULLY);
      137 |     });
      138 | });

      at Object.toHaveBeenCalledTimes (tests/test_utils/auth_utils.test.js:135:54)


  ● bufferHandler › SocketEvents: onMessage, Valid Deleted file

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      599 |         const handled = await webSocketEvents.onMessage(msg);
      600 |         expect(handled).toBe(true);
    > 601 |         expect(fs.existsSync(shadowFilePath)).toBe(false);
          |                                               ^
      602 |         expect(global.socketConnection.send).toHaveBeenCalledTimes(2);
      603 |         expect(JSON.parse(global.socketConnection.send.mock.calls[0][0]).auth).toStrictEqual(200);
      604 |         const diffJSON = JSON.parse(global.socketConnection.send.mock.calls[1][0]).diffs[0];

      at Object.toBe (tests/test_codesyncd/buffer_handler.test.js:601:47)

Report generated by 🧪jest coverage report action from e936c36

@Basit-qc Basit-qc changed the title (WIP) Prompting user to select Org/Team during Connect Repo Prompting user to select Org/Team during Connect Repo Jan 17, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Basit-qc Basit-qc merged commit d8bd76d into develop Jan 22, 2025
2 of 7 checks passed
@Basit-qc Basit-qc deleted the simplify-onboarding branch January 22, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants