Skip to content

Conversation

@Basit-qc
Copy link
Contributor

No description provided.

@Basit-qc Basit-qc requested a review from saadberry December 25, 2024 11:34
@github-actions
Copy link

github-actions bot commented Dec 25, 2024

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/yarn' failed with exit code 1
St.
Category Percentage Covered / Total
🟢 Statements
81.75% (-0.56% 🔻)
2643/3233
🟡 Branches
70.34% (+1.02% 🔼)
906/1288
🟢 Functions
80.88% (-2.6% 🔻)
368/455
🟢 Lines
84.02% (-0.66% 🔻)
2493/2967
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / s3_uploader.ts
77.31% 56.41% 96% 83.16%
🟢
... / utils.ts
97.32% 82% 100% 99.05%
🟢
... / connect_repo_handler.ts
88.68% 86.21% 66.67% 88.24%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / api_utils.ts
49.28% (-44.06% 🔻)
56.25% (-27.08% 🔻)
50% (-43.75% 🔻)
49.28% (-44.06% 🔻)
🔴
... / notifications.ts
33% (-19.46% 🔻)
20.83% (-7.74% 🔻)
35% (-18.85% 🔻)
36.26% (-17.97% 🔻)

Test suite run failed

Failed tests: 5/310. Failed suites: 3/28.
  ● handleRenameFile › For File in sub directory

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      242 |     const renamedShadowFilePath = path.join(shadowRepoBranchPath, newRelPath);
      243 |     // Verify file has been renamed in the shadow repo
    > 244 |     expect(fs.existsSync(oldShadowFilePath)).toBe(false);
          |                                              ^
      245 |     expect(fs.existsSync(renamedShadowFilePath)).toBe(true);
      246 |     // Verify correct diff file has been generated
      247 |     let diffFiles = fs.readdirSync(diffsRepo);

      at toBe (tests/helpers/helpers.js:244:46)
      at Object.<anonymous> (tests/test_events/handler/handleRename.test.js:234:33)

  ● handleRenameFile › For file renamed in sub directory

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      242 |     const renamedShadowFilePath = path.join(shadowRepoBranchPath, newRelPath);
      243 |     // Verify file has been renamed in the shadow repo
    > 244 |     expect(fs.existsSync(oldShadowFilePath)).toBe(false);
          |                                              ^
      245 |     expect(fs.existsSync(renamedShadowFilePath)).toBe(true);
      246 |     // Verify correct diff file has been generated
      247 |     let diffFiles = fs.readdirSync(diffsRepo);

      at toBe (tests/helpers/helpers.js:244:46)
      at Object.<anonymous> (tests/test_events/handler/handleRename.test.js:324:33)


  ● logoutHandler › Verify Logout URL

    expect(jest.fn()).toHaveBeenCalledTimes(expected)

    Expected number of calls: 1
    Received number of calls: 2

      133 |         expect(vscode.commands.executeCommand.mock.calls[0][2]).toBe(true);
      134 |         await waitFor(2);
    > 135 |         expect(vscode.window.showInformationMessage).toHaveBeenCalledTimes(1);
          |                                                      ^
      136 |         expect(vscode.window.showInformationMessage.mock.calls[0][0]).toStrictEqual(NOTIFICATION.LOGGED_OUT_SUCCESSFULLY);
      137 |     });
      138 | });

      at Object.toHaveBeenCalledTimes (tests/test_utils/auth_utils.test.js:135:54)


  ● bufferHandler › SocketEvents: onMessage, New File Diff along with changes diff

    expect(received).toHaveLength(expected)

    Expected length: 1
    Received length: 2
    Received array:  ["1737564025613.yml", "1737564026637.yml"]

      167 |         // Verify correct diff file has been generated
      168 |         let diffFiles = fs.readdirSync(diffsRepo);
    > 169 |         expect(diffFiles).toHaveLength(diffsCount);
          |                           ^
      170 |         return true;
      171 |     };
      172 |

      at toHaveLength (tests/test_codesyncd/buffer_handler.test.js:169:27)
      at Object.assertDiffsCount (tests/test_codesyncd/buffer_handler.test.js:482:16)

  ● bufferHandler › SocketEvents: onMessage, Valid Deleted file

    expect(received).toBe(expected) // Object.is equality

    Expected: false
    Received: true

      599 |         const handled = await webSocketEvents.onMessage(msg);
      600 |         expect(handled).toBe(true);
    > 601 |         expect(fs.existsSync(shadowFilePath)).toBe(false);
          |                                               ^
      602 |         expect(global.socketConnection.send).toHaveBeenCalledTimes(2);
      603 |         expect(JSON.parse(global.socketConnection.send.mock.calls[0][0]).auth).toStrictEqual(200);
      604 |         const diffJSON = JSON.parse(global.socketConnection.send.mock.calls[1][0]).diffs[0];

      at Object.toBe (tests/test_codesyncd/buffer_handler.test.js:601:47)

Report generated by 🧪jest coverage report action from d8bd76d

CHANGELOG.md Outdated
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [4.6.0] - 2024-12-25
- Swithchin off daily-activity-alert since we now have Slack Alerts enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo here

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Basit-qc Basit-qc changed the title Turning off daily-activity-alert Simplified Onboarding Flow Jan 22, 2025
@Basit-qc Basit-qc merged commit 924530a into master Jan 23, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants