Issue 14 create first two sections of landing page #31
Conversation
laurenpudz
left a comment
laurenpudz
left a comment
There was a problem hiding this comment.
A really great start, just some things to consider :)
client/src/pages/landing.tsx
Outdated
| </div> | ||
| </div> | ||
|
|
||
| <div className="flex h-[280px] w-[400px] items-center justify-center rounded-xl bg-[#cfc2ff]"> |
There was a problem hiding this comment.
Please use the custom project colours wherever you can. There should be a matching colour for this somewhere. If one doesn't exist (and you are reusing this colour in other places), you can create one.
laurenpudz
left a comment
laurenpudz
left a comment
There was a problem hiding this comment.
Really great progress, just still need to fix up the colours, plus a couple of other things I just noticed. Keep up the good work :)
laurenpudz
left a comment
laurenpudz
left a comment
There was a problem hiding this comment.
Just some finishing touches then should be good to go!
There was a problem hiding this comment.
We can add the bomb decoration and sparkles in a later PR so don't worry about adding this for now :)
also please make sure the prettier check is passing, it looks to be failing at the moment |
client/src/styles/globals.css
Outdated
|
|
||
| --landing-card3: 232, 50.8%, 12%; | ||
|
|
||
| --landing-border:235.1, 47.6%, 20%; |
There was a problem hiding this comment.
Adding this shouldn't be necessary, you should just be able to use muted
client/src/styles/globals.css
Outdated
| --destructive: 0 62.8% 30.6%; | ||
| --destructive-foreground: 0 0% 100%; | ||
|
|
||
| --landing-card1: 250, 44.3%, 15.5%; |
There was a problem hiding this comment.
We can use dark-alt for this colour, as it is very similar. Really sorry for inconsistencies on the figma, this colour should be the same as what is used in the background of the already existing feature box component.
client/src/styles/globals.css
Outdated
|
|
||
| --landing-card1: 250, 44.3%, 15.5%; | ||
|
|
||
| --landing-card2: 277 100% 62% / 0.1; |
There was a problem hiding this comment.
This should also be dark-alt. Sorry again for figma inconsistencies
laurenpudz
left a comment
laurenpudz
left a comment
There was a problem hiding this comment.
Looking good, happy to approve! Thanks for all your hard work on this issue
Change Summary
Implemented the first two sections of the Landing Page.
Added gage title, description and event cards.
Basic layout and styling in Tailwind completed.
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
Related issue