-
Notifications
You must be signed in to change notification settings - Fork 98
refactor(vscode-web): migrate to VS Code CLI with code serve-web #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
matifali
commented
Dec 31, 2025
- Replace code-server with official VS Code CLI
- Download CLI from code.visualstudio.com using cli-alpine-* URLs
- Add release_channel variable (stable/insiders)
- Add commit_id variable to pin specific VS Code versions
- Support offline mode with fallback to code-server or cached vscode-server
- Add comprehensive bun tests for settings, extensions, and CLI arguments
- Add Terraform tests for variable validation
- Replace code-server with official VS Code CLI - Download CLI from code.visualstudio.com using cli-alpine-* URLs - Add release_channel variable (stable/insiders) - Add commit_id variable to pin specific VS Code versions - Support offline mode with fallback to code-server or cached vscode-server - Add comprehensive bun tests for settings, extensions, and CLI arguments - Add Terraform tests for variable validation
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the vscode-web module to use the official VS Code CLI instead of code-server, enabling better version control and alignment with official VS Code tooling.
- Migrates from code-server to official VS Code CLI with
code serve-webcommand - Adds
release_channelvariable to support stable/insiders releases - Implements comprehensive offline mode with fallback to code-server or cached vscode-server
- Adds extensive test coverage with 21 new integration tests
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| main.tf | Removes platform variable, adds release_channel and repositions commit_id variable with updated description |
| run.sh | Complete rewrite to download and use VS Code CLI instead of code-server, with offline fallback mechanisms |
| main.test.ts | Adds comprehensive test suite with 21 tests covering script generation, settings management, extension installation, and container integration |
| vscode-web.tftest.hcl | New Terraform validation tests for variable constraints and URL generation |
| README.md | Updates documentation to reflect VS Code CLI usage and new configuration options |
Separate declaration and assignment for local variable to avoid masking return values.