Open
Conversation
denis-zaichenko
changed the title
denis-zaichenko
changed the title
dimagreat
requested changes
Jul 27, 2020
| @@ -0,0 +1,469 @@ | |||
| # Clear code | |||
Member
There was a problem hiding this comment.
This is same as we have in javascript file
|
|
||
| Now I am creating some simple form from login to site. | ||
|
|
||
|  |
Member
There was a problem hiding this comment.
It's better to write code instead of using pictures.
|
|
||
|  | ||
|
|
||
| Reading got easier. The name of the component corresponds to the problem it solves. The purpose of the element is evident. There is less code. So we are heading in the right direction! |
Member
There was a problem hiding this comment.
Decrease amount of words in this file
|
|
||
| [Return to Typescript](./README.md). | ||
|
|
||
| #### `Partial <T>` - constructs a type with all properties of `T` set to optional. |
Member
There was a problem hiding this comment.
Decrease explanation here and put this info to all typescript document
| 4. [Development](docs/development.md) | ||
| 5. [Tools](docs/tools.md) | ||
| 6. [Git Flow](docs/git.md) | ||
| 7. [Clear code](docs/clear-code/README.md) |
Member
There was a problem hiding this comment.
Better put this info about patterns to react doc with namereact-clean-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading these articles, not merge, please, I combine commits.