Skip to content

Conversation

@vladimirleonidovich
Copy link

Description

It compiles, but I cannot guarantee if it actually works because I am not a 10x engineer (😭) and the PR possibly contains runtime errors. Please review it carefully before merging.

Fixes #139

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

I can’t figure out if it’s a breaking change or not.

Checklist:

  • My code follows the style guidelines of this project / let’s make sure I did not break anything, and if my code does not follow the style guidelines, I’ll make additional commits to match the style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas /
  • I have made corresponding changes to the documentation / let’s make sure I did not break anything first
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules / ?

@codefiesta
Copy link
Owner

Closing in favor of PR #142

@codefiesta codefiesta closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lower Minimum Required OS Versions

2 participants