Sample review #12
Sample review #12
Conversation
|
👋 Review this Pull Request on CodeApprove here: |
Automated comment from CodeApprove (go to review)⏳ @Wincini please review this Pull Request |
hatboysam
left a comment
hatboysam
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
In: Discussion
Adding a comment on my own review, this one is unresolved.
In: difftest.ts:
> Line 10
console.log("added line");
Adding a resolved comment, inline.
👀 @Wincini it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
Automated comment from CodeApprove (go to review)⏳ @hatboysam-test please review this Pull Request |
alicethecoder
left a comment
alicethecoder
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
In: Discussion
I think that makes sense.
In: Discussion
Resolved
In: difftest.ts:
> Line 10
console.log("added line");
Cool!
In: fib.js:
> Line 4
const number = parseInt(prompt('Enter the number of terms: '));
I think it's weird to use number as a variable name since it's also a type name.
👀 @Wincini,@hatboysam it's your turn please take a look
alicethecoder
left a comment
alicethecoder
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @Wincini,@hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
✔️ Approved (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
Wincini
left a comment
Wincini
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
❌ Undo Approval (1 unresolved comments)
👀 @hatboysam it's your turn please take a look
hatboysam
left a comment
hatboysam
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
In: fib.js:
> Line 4
const number = parseInt(prompt('Enter the number of terms: '));
Resolved
👀 @Wincini it's your turn please take a look
alicethecoder
left a comment
alicethecoder
left a comment
There was a problem hiding this comment.
Automated comment from CodeApprove (go to review)
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Automated comment from CodeApprove (go to review)⏳ @j-strelioff please review this Pull Request |
This is the description, it can be written in markdown