Merge pull request #1184 from code-corps/add-processor

Add processor that switches between sync/async

Author: joshsmith

config/config.exs

@@ -82,6 +82,8 @@ config :sentry,
   included_environments: ~w(prod staging)a,
   use_error_logger: true
 
+config :code_corps, :processor, CodeCorps.Processor.Async
+
 # Import environment specific config. This must remain at the bottom
 # of this file so it overrides the configuration defined above.
 import_config "#{Mix.env}.exs"

config/test.exs

@@ -57,6 +57,8 @@ config :code_corps,
 config :sentry,
   environment_name: Mix.env || :test
 
+config :code_corps, :processor, CodeCorps.Processor.Sync
+
 config :code_corps, CodeCorps.Mailer,
   adapter: Bamboo.TestAdapter
 

lib/code_corps/accounts/accounts.ex

@@ -5,13 +5,13 @@ defmodule CodeCorps.Accounts do
   All actions to accounts should go through here.
   """
 
-  alias Task.Supervisor, as: TaskSupervisor
   alias CodeCorps.{
     Accounts.Changesets,
     Comment,
     GitHub.Adapters,
     GithubAppInstallation,
     GithubUser,
+    Processor,
     Task,
     User,
     Repo
@@ -124,7 +124,7 @@ defmodule CodeCorps.Accounts do
   end
 
   defp upload_github_photo_async(%User{cloudinary_public_id: nil} = user) do
-    TaskSupervisor.start_child(:background_processor, fn -> upload_github_photo(user) end)
+    Processor.process(fn -> upload_github_photo(user) end)
   end
   defp upload_github_photo_async(%User{} = user), do: user
 

lib/code_corps/github/webhook/processor.ex

@@ -5,7 +5,7 @@ defmodule CodeCorps.GitHub.Webhook.Processor do
   Can process them synchronously or asynchronously.
   """
 
-  alias CodeCorps.GitHub.Webhook.Handler
+  alias CodeCorps.{GitHub.Webhook.Handler, Processor}
 
   @doc """
   Used to process a Github webhook event in an async manner.
@@ -15,7 +15,7 @@ defmodule CodeCorps.GitHub.Webhook.Processor do
   Returns `{:ok, pid}`
   """
   def process_async(type, id, payload) do
-    Task.Supervisor.start_child(:background_processor, fn -> process(type, id, payload) end)
+    Processor.process(fn -> process(type, id, payload) end)
   end
 
   defdelegate process(type, id, payload), to: Handler, as: :handle

lib/code_corps/processor/async.ex

@@ -0,0 +1,9 @@
+defmodule CodeCorps.Processor.Async do
+  @behaviour CodeCorps.Processor
+
+  def process(fun) do
+    Task.Supervisor.start_child(:background_processor, fn ->
+      apply(fun, [])
+    end)
+  end
+end

lib/code_corps/processor/processor.ex

@@ -0,0 +1,9 @@
+defmodule CodeCorps.Processor do
+  @processor Application.get_env(:code_corps, :processor)
+
+  @callback process(fun :: (() -> any)) :: any
+
+  def process(fun) do
+    @processor.process(fun)
+  end
+end

lib/code_corps/processor/sync.ex

@@ -0,0 +1,7 @@
+defmodule CodeCorps.Processor.Sync do
+  @behaviour CodeCorps.Processor
+
+  def process(fun) do
+    apply(fun, [])
+  end
+end

lib/code_corps/stripe_service/webhook_processing/webhook_processor.ex

@@ -3,7 +3,7 @@ defmodule CodeCorps.StripeService.WebhookProcessing.WebhookProcessor do
   Used to process a Stripe webhook request.
   """
 
-  alias CodeCorps.StripeService.WebhookProcessing.EventHandler
+  alias CodeCorps.{Processor, StripeService.WebhookProcessing.EventHandler}
 
   @api Application.get_env(:code_corps, :stripe)
 
@@ -18,7 +18,7 @@ defmodule CodeCorps.StripeService.WebhookProcessing.WebhookProcessor do
   Returns `{:ok, pid}`
   """
   def process_async(event_params, handler) do
-    Task.Supervisor.start_child(:background_processor, fn -> process(event_params, handler) end)
+    Processor.process(fn -> process(event_params, handler) end)
   end
 
   @doc """

lib/code_corps_web/controllers/project_github_repo_controller.ex

@@ -3,7 +3,7 @@ defmodule CodeCorpsWeb.ProjectGithubRepoController do
   use CodeCorpsWeb, :controller
 
   alias Task.Supervisor, as: TaskSupervisor
-  alias CodeCorps.{Analytics.SegmentTracker, ProjectGithubRepo, User, Helpers.Query}
+  alias CodeCorps.{Analytics.SegmentTracker, Processor, ProjectGithubRepo, User, Helpers.Query}
 
   action_fallback CodeCorpsWeb.FallbackController
   plug CodeCorpsWeb.Plug.DataToAttributes
@@ -29,7 +29,7 @@ defmodule CodeCorpsWeb.ProjectGithubRepoController do
          {:ok, :authorized} <- current_user |> Policy.authorize(:create, %ProjectGithubRepo{}, params),
          {:ok, %ProjectGithubRepo{} = project_github_repo} <- create_project_repo_changeset(params) |> Repo.insert do
 
-      TaskSupervisor.start_child(:background_processor, fn ->
+      Processor.process(fn ->
         CodeCorps.GitHub.Sync.sync_project_github_repo(project_github_repo)
       end)
 

mix.lock

@@ -15,10 +15,10 @@
   "cowlib": {:hex, :cowlib, "1.0.2", "9d769a1d062c9c3ac753096f868ca121e2730b9a377de23dec0f7e08b1df84ee", [], []},
   "credo": {:hex, :credo, "0.8.6", "335f723772d35da499b5ebfdaf6b426bfb73590b6fcbc8908d476b75f8cbca3f", [:mix], [{:bunt, "~> 0.2.0", [hex: :bunt, optional: false]}]},
   "db_connection": {:hex, :db_connection, "1.1.2", "2865c2a4bae0714e2213a0ce60a1b12d76a6efba0c51fbda59c9ab8d1accc7a8", [:mix], [{:connection, "~> 1.0.2", [hex: :connection, optional: false]}, {:poolboy, "~> 1.5", [hex: :poolboy, optional: true]}, {:sbroker, "~> 1.0", [hex: :sbroker, optional: true]}]},
-  "decimal": {:hex, :decimal, "1.4.0", "fac965ce71a46aab53d3a6ce45662806bdd708a4a95a65cde8a12eb0124a1333", [:mix], []},
+  "decimal": {:hex, :decimal, "1.4.0", "fac965ce71a46aab53d3a6ce45662806bdd708a4a95a65cde8a12eb0124a1333", [:mix], [], "hexpm"},
   "dialyxir": {:hex, :dialyxir, "0.5.1", "b331b091720fd93e878137add264bac4f644e1ddae07a70bf7062c7862c4b952", [:mix], []},
   "earmark": {:hex, :earmark, "1.2.3", "206eb2e2ac1a794aa5256f3982de7a76bf4579ff91cb28d0e17ea2c9491e46a4", [:mix], []},
-  "ecto": {:hex, :ecto, "2.2.2", "e9bd6ebc044eaaab1cb369e3465686d8aca830aa5bf545ef2bae000a3d42c54b", [:mix], [{:db_connection, "~> 1.1", [hex: :db_connection, optional: true]}, {:decimal, "~> 1.2", [hex: :decimal, optional: false]}, {:mariaex, "~> 0.8.0", [hex: :mariaex, optional: true]}, {:poison, "~> 2.2 or ~> 3.0", [hex: :poison, optional: true]}, {:poolboy, "~> 1.5", [hex: :poolboy, optional: false]}, {:postgrex, "~> 0.13.0", [hex: :postgrex, optional: true]}, {:sbroker, "~> 1.0", [hex: :sbroker, optional: true]}]},
+  "ecto": {:hex, :ecto, "2.2.2", "e9bd6ebc044eaaab1cb369e3465686d8aca830aa5bf545ef2bae000a3d42c54b", [:mix], [{:db_connection, "~> 1.1", [repo: "hexpm", hex: :db_connection, optional: true]}, {:decimal, "~> 1.2", [repo: "hexpm", hex: :decimal, optional: false]}, {:mariaex, "~> 0.8.0", [repo: "hexpm", hex: :mariaex, optional: true]}, {:poison, "~> 2.2 or ~> 3.0", [repo: "hexpm", hex: :poison, optional: true]}, {:poolboy, "~> 1.5", [repo: "hexpm", hex: :poolboy, optional: false]}, {:postgrex, "~> 0.13.0", [repo: "hexpm", hex: :postgrex, optional: true]}, {:sbroker, "~> 1.0", [repo: "hexpm", hex: :sbroker, optional: true]}], "hexpm"},
   "ecto_ordered": {:hex, :ecto_ordered, "0.2.0-beta1", "cb066bc608f1c8913cea85af8293261720e6a88e3c99061e6877d7025352f045", [:mix], [{:ecto, "~> 2.0", [hex: :ecto, optional: false]}]},
   "elixir_make": {:hex, :elixir_make, "0.4.0", "992f38fabe705bb45821a728f20914c554b276838433349d4f2341f7a687cddf", [:mix], []},
   "ex_aws": {:hex, :ex_aws, "1.1.4", "4bdc4fff91f8d35c7fe2355b9da54cc51f980c92f1137715d8b2d70d8e8511cc", [:mix], [{:configparser_ex, "~> 0.2.1", [hex: :configparser_ex, optional: true]}, {:hackney, "1.6.3 or 1.6.5 or 1.7.1 or 1.8.6 or ~> 1.9", [hex: :hackney, optional: true]}, {:jsx, "~> 2.8", [hex: :jsx, optional: true]}, {:poison, ">= 1.2.0", [hex: :poison, optional: true]}, {:sweet_xml, "~> 0.6", [hex: :sweet_xml, optional: true]}, {:xml_builder, "~> 0.1.0", [hex: :xml_builder, optional: true]}]},
@@ -44,8 +44,8 @@
   "money": {:hex, :money, "1.2.1", "fdcc7b021b894dbcc2cd0f57d2ccdd2224eced747231337a849424ffaa196b13", [:mix], [{:ecto, "~> 1.0 or ~> 2.0 or ~> 2.1", [hex: :ecto, optional: true]}, {:phoenix_html, "~> 2.0", [hex: :phoenix_html, optional: true]}]},
   "msgpax": {:hex, :msgpax, "1.1.0", "e31625e256db2decca1ae2b841f21b4d2483b1332649ce3ebc96c7ff7a4986e3", [:mix], [{:plug, "~> 1.0", [hex: :plug, optional: true]}]},
   "phoenix": {:hex, :phoenix, "1.3.0", "1c01124caa1b4a7af46f2050ff11b267baa3edb441b45dbf243e979cd4c5891b", [:mix], [{:cowboy, "~> 1.0", [hex: :cowboy, optional: true]}, {:phoenix_pubsub, "~> 1.0", [hex: :phoenix_pubsub, optional: false]}, {:plug, "~> 1.3.3 or ~> 1.4", [hex: :plug, optional: false]}, {:poison, "~> 2.2 or ~> 3.0", [hex: :poison, optional: false]}]},
-  "phoenix_ecto": {:hex, :phoenix_ecto, "3.2.3", "450c749876ff1de4a78fdb305a142a76817c77a1cd79aeca29e5fc9a6c630b26", [:mix], [{:ecto, "~> 2.1", [hex: :ecto, optional: false]}, {:phoenix_html, "~> 2.9", [hex: :phoenix_html, optional: true]}, {:plug, "~> 1.0", [hex: :plug, optional: false]}]},
-  "phoenix_html": {:hex, :phoenix_html, "2.10.4", "d4f99c32d5dc4918b531fdf163e1fd7cf20acdd7703f16f5d02d4db36de803b7", [:mix], [{:plug, "~> 1.0", [hex: :plug, optional: false]}]},
+  "phoenix_ecto": {:hex, :phoenix_ecto, "3.2.3", "450c749876ff1de4a78fdb305a142a76817c77a1cd79aeca29e5fc9a6c630b26", [:mix], [{:ecto, "~> 2.1", [repo: "hexpm", hex: :ecto, optional: false]}, {:phoenix_html, "~> 2.9", [repo: "hexpm", hex: :phoenix_html, optional: true]}, {:plug, "~> 1.0", [repo: "hexpm", hex: :plug, optional: false]}], "hexpm"},
+  "phoenix_html": {:hex, :phoenix_html, "2.10.4", "d4f99c32d5dc4918b531fdf163e1fd7cf20acdd7703f16f5d02d4db36de803b7", [:mix], [{:plug, "~> 1.0", [repo: "hexpm", hex: :plug, optional: false]}], "hexpm"},
   "phoenix_live_reload": {:hex, :phoenix_live_reload, "1.0.8", "4333f9c74190f485a74866beff2f9304f069d53f047f5fbb0fb8d1ee4c495f73", [:mix], [{:fs, "~> 0.9.1", [hex: :fs, optional: false]}, {:phoenix, "~> 1.0 or ~> 1.2-rc", [hex: :phoenix, optional: false]}]},
   "phoenix_pubsub": {:hex, :phoenix_pubsub, "1.0.2", "bfa7fd52788b5eaa09cb51ff9fcad1d9edfeb68251add458523f839392f034c1", [:mix], []},
   "plug": {:hex, :plug, "1.4.3", "236d77ce7bf3e3a2668dc0d32a9b6f1f9b1f05361019946aae49874904be4aed", [:mix], [{:cowboy, "~> 1.0.1 or ~> 1.1", [hex: :cowboy, optional: true]}, {:mime, "~> 1.0", [hex: :mime, optional: false]}]},