Merge pull request #1182 from code-corps/fix-order-of-github-events

Fix order of github events

Author: joshsmith

lib/code_corps_web/controllers/github_event_controller.ex

@@ -19,7 +19,7 @@ defmodule CodeCorpsWeb.GithubEventController do
       github_events =
         GithubEvent
         |> Query.id_filter(params)
-        |> Ecto.Query.order_by([asc: :inserted_at])
+        |> Ecto.Query.order_by([desc: :inserted_at])
         |> paginate(params)
 
       conn |> render("index.json-api", data: github_events)

priv/repo/structure.sql

@@ -2,8 +2,8 @@
 -- PostgreSQL database dump
 --
 
--- Dumped from database version 9.5.9
--- Dumped by pg_dump version 10.0
+-- Dumped from database version 9.5.10
+-- Dumped by pg_dump version 10.1
 
 SET statement_timeout = 0;
 SET lock_timeout = 0;

test/lib/code_corps_web/controllers/github_event_controller_test.exs

@@ -28,19 +28,19 @@ defmodule CodeCorpsWeb.GithubEventControllerTest do
     end
 
     @tag authenticated: :admin
-    test "lists all entries on index by inserted_at", %{conn: conn} do
-      github_event_1 = insert(:github_event, inserted_at: Timex.now())
-      github_event_2 = insert(:github_event, inserted_at: Timex.now() |> Timex.shift(days: 3))
+    test "lists all entries on index by inserted_at desc", %{conn: conn} do
+      past_event = insert(:github_event, inserted_at: Timex.now())
+      recent_event = insert(:github_event, inserted_at: Timex.now() |> Timex.shift(days: 3))
 
-      data = 
+      data =
         conn
         |> request_index
         |> json_response(200)
         |> Map.get("data")
 
       [first_event, second_event] = data
-      assert first_event["id"] == github_event_1.id |> Integer.to_string
-      assert second_event["id"] == github_event_2.id |> Integer.to_string
+      assert first_event["id"] == recent_event.id |> Integer.to_string
+      assert second_event["id"] == past_event.id |> Integer.to_string
     end
 
     @tag authenticated: :admin