This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Add TYPO3 version 9 Compatibility #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/0.0.7
…to feature/update-9 # Conflicts: # Classes/Configuration/ConfigurationContainer.php
Add missing return statement
DanielSiepmann
force-pushed
the
feature/update-9
branch
from
65fb7fd to
b09697f
Compare
Do not introduce unnecessary changes into pull request for TYPO3 CMS 9 update. * Trim trailing whitespace. * Do not introduce blank line before namespace definition with this pull request. * Add posix new line at end of file.
DanielSiepmann
force-pushed
the
feature/update-9
branch
from
b09697f to
c940ac4
Compare
Keep old code and behaviour. Adjust only a single place to keep old expected behaviour. If TYPO3 throws an exception, catch this, and replace it by old behaviour which is already handled throughout the code.
Instead return expected object type.
Main goal is to allow Travis to run builds again. Beside that, we do no longer support TYPO3 CMS 7, but 8.7 and 9.5.
* Add some more checks to remove PHP warnings / notices. * Adjust code to match CMS 9 API / interfaces. * Do no longer use "query" but only searchTerm, as query is internal API.
This was done by TYPO3 itself before Version 9. Since version 9, we have to take care ourselves.
Keep changed for pull request to a necessary minimum.
There is no need to require anything, as only a single TYPO3 version is supported.
Conflicts:
Documentation/source/changelog.rst
Makefile
DanielSiepmann
force-pushed
the
feature/update-9
branch
from
c32f6c1 to
32a04fb
Compare
* Remove no longer necessary code. * Improve changelog for cms 9.
DanielSiepmann
approved these changes
Jun 6, 2019
justusmoroni
suggested changes
Jul 12, 2019
| { | ||
| $filter = \TYPO3\CMS\Core\Utility\ArrayUtility::removeArrayEntryByValue($filter, ''); | ||
| $this->filter = \TYPO3\CMS\Extbase\Utility\ArrayUtility::removeEmptyElementsRecursively($filter); | ||
| $this->filter = \TYPO3\CMS\Core\Utility\ArrayUtility::filterRecursive($filter, function ($value) { |
Member
There was a problem hiding this comment.
Use use statements here. Check everywhere?
| Therefore also PHP class ``\Codappix\SearchCore\Domain\Model\SearchRequest`` has | ||
| been adjusted. | ||
|
|
||
| * Recycler are respected. Pages from type recycler are ignored during indexing. |
Member
There was a problem hiding this comment.
Change Recycler are respected to Recycler is respected?
| { | ||
| $filter = \TYPO3\CMS\Core\Utility\ArrayUtility::removeArrayEntryByValue($filter, ''); | ||
| $this->filter = \TYPO3\CMS\Extbase\Utility\ArrayUtility::removeEmptyElementsRecursively($filter); | ||
| $this->filter = \TYPO3\CMS\Core\Utility\ArrayUtility::filterRecursive($filter, function ($value) { |
Member
There was a problem hiding this comment.
Use use statements here. Check everywhere where necessary?
| ], | ||
| 'field2' => [ | ||
| 'config' => '{request.query}', | ||
| 'config' => '{request.searchTerm}', |
Member
There was a problem hiding this comment.
Is this change still valid? Check if you want to use {request.query} or {request.searchTerm}.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accepting this pull request
search_corewill be compatible with both TYPO3 version 8 and the new 9 LTS.The Compatibility to version 7.6 was dropped!