.editorconfig: Added .editorconfig file#643
Open
shakeelsamsu wants to merge 2 commits intocoala:masterfrom
shakeelsamsu:editorconfig
Open
.editorconfig: Added .editorconfig file#643shakeelsamsu wants to merge 2 commits intocoala:masterfrom shakeelsamsu:editorconfig
shakeelsamsu wants to merge 2 commits intocoala:masterfrom
shakeelsamsu:editorconfig
Conversation
nvzard
suggested changes
Nov 5, 2018
Member
nvzard
left a comment
There was a problem hiding this comment.
Please modify your commit message as per the commit guidelines :)
http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html
Author
|
Done. |
jayvdb
requested changes
Nov 6, 2018
Member
jayvdb
left a comment
There was a problem hiding this comment.
This task requires adding .editorconfig to the sync list in .moban.yaml
Commit message doesnt comply with https://coala.io/commit .
jayvdb
requested changes
Nov 6, 2018
| [**] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| insert_final_newline = truemax_line_length = 80 |
Member
There was a problem hiding this comment.
what the .. this doesnt look right....
naveenkumarsangi
requested changes
Nov 6, 2018
Member
naveenkumarsangi
left a comment
There was a problem hiding this comment.
Missing .editorconfig.jj2template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added .editorconfig file for Python and YAML
Closes #331
Reviewers Checklist
botcmdandre_botcmddecorators.