Re_botcmd_fullmatch: Add re_botcmd_fullmatch#403
Re_botcmd_fullmatch: Add re_botcmd_fullmatch#403meetmangukiya wants to merge 1 commit intomasterfrom
Conversation
plugins/re_botcmd_fullmatch.py
Outdated
| """ | ||
| Triggers on plugin activation | ||
|
|
||
| You should delete it if you're not using it to override any default behaviour |
There was a problem hiding this comment.
E501 line too long (85 > 80 characters)
Origin: PycodestyleBear (E501), Section: all.autopep8.
plugins/re_botcmd_fullmatch.py
Outdated
| """ | ||
| Triggers on plugin activation | ||
|
|
||
| You should delete it if you're not using it to override any default behaviour |
There was a problem hiding this comment.
Line is longer than allowed. (85 > 80)
Origin: LineLengthBear, Section: all.linelength.
meetmangukiya
force-pushed
the
meet/re-fullmath
branch
from
29d68e3 to
f9dc5d6
Compare
|
|
||
| @botcmd | ||
| def check_regexes(self, msg, args) | ||
| if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'): |
There was a problem hiding this comment.
E113 unexpected indentation
Origin: PycodestyleBear (E113), Section: all.autopep8.
meetmangukiya
force-pushed
the
meet/re-fullmath
branch
from
f9dc5d6 to
106d26e
Compare
|
|
||
| @botcmd | ||
| def check_regexes(self, msg, args) | ||
| if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'): |
There was a problem hiding this comment.
E113 unexpected indentation
Origin: PycodestyleBear (E113), Section: all.autopep8.
meetmangukiya
force-pushed
the
meet/re-fullmath
branch
from
106d26e to
73ad68c
Compare
|
|
||
| @botcmd | ||
| def check_regexes(self, msg, args) | ||
| if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'): |
There was a problem hiding this comment.
E113 unexpected indentation
Origin: PycodestyleBear (E113), Section: all.autopep8.
meetmangukiya
force-pushed
the
meet/re-fullmath
branch
from
73ad68c to
892462c
Compare
meetmangukiya
force-pushed
the
meet/re-fullmath
branch
from
892462c to
7d9a3b5
Compare
|
test coverage ;) |
| from errbot import BotPlugin, botcmd | ||
|
|
||
|
|
||
| class Re_botcmd_fullmatch(BotPlugin): |
There was a problem hiding this comment.
rather than a plugin, we should not use re_botcmd , and instead use a better decorator which does this check and then defers to re_botcmd
5 participants
Closes #402
Reviewers Checklist
botcmdandre_botcmddecorators.