Open
Conversation
rcunrau
commented
Jul 28, 2023
rcunrau
commented
- include ANTLR environment variable changes
- switch from LLVM to MLIR
- tested with the empty grammar
quinnlp
approved these changes
Jul 31, 2023
Contributor
quinnlp
left a comment
quinnlp
left a comment
There was a problem hiding this comment.
other than my curiosity about the cmake policy this lgtm
CMakeLists.txt
Outdated
| @@ -1,13 +1,14 @@ | |||
| cmake_minimum_required(VERSION 3.0) | |||
| cmake_policy(SET CMP0075 NEW) | |||
Contributor
There was a problem hiding this comment.
Could you try unsetting the CMP0075 policy and setting the cmake minimum to 3.12. I don't understand this cmake policy stuff well and I'm curious to see if it works based on this conversation: https://reviews.llvm.org/D82074
Author
There was a problem hiding this comment.
It works :-)
I also changed it in VCalcBase
… rid of the warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.