Implement missing storage-cli operations for AliCloud #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
from
565a6eb to
1699400
Compare
24 tasks
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
from
f6f5c44 to
2bfbdec
Compare
jochenehret
reviewed
Nov 27, 2025
jochenehret
reviewed
Nov 27, 2025
jochenehret
reviewed
Nov 27, 2025
beyhan
requested review from
a team,
peanball and
serdarozerr
and removed request for
a team
beyhan
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
There was a problem hiding this comment.
Pull request overview
This PR implements five missing storage-cli operations for AliCloud (Alibaba Cloud OSS): copy, delete-recursive, list, properties, and ensure-bucket-exists. These operations bring AliCloud feature parity with other storage providers in the storage-cli tool.
Key Changes
- Added CLI command handlers for the five new operations with argument validation
- Implemented the underlying storage client methods with pagination support for list and delete-recursive operations
- Added comprehensive integration tests for all new operations
- Modified the storage client initialization to cache OSS client and bucket instances
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| alioss/main.go | Added command handlers for copy, delete-recursive, list, properties, and ensure-bucket-exists with argument validation |
| alioss/client/storage_client.go | Implemented five new storage operations, modified struct to cache client/bucket instances, added BlobProperties type |
| alioss/client/client.go | Added wrapper methods in AliBlobstore to delegate to storage client implementations |
| alioss/integration/general_ali_test.go | Added integration tests for delete-recursive, copy, list, and ensure-bucket-exists operations |
| alioss/client/clientfakes/fake_storage_client.go | Auto-generated fake client code for new interface methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
2 times, most recently
from
804c940 to
9de39f7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
2 times, most recently
from
69237db to
76d7d77
Compare
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
from
76d7d77 to
02a1735
Compare
Missing Operations: copy, delete-recursive, list, properties, ensure-bucket-exists.
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
from
02a1735 to
4df1287
Compare
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
from
cf423f4 to
ee97fc4
Compare
serdarozerr
reviewed
Dec 12, 2025
serdarozerr
reviewed
Dec 17, 2025
Contributor
serdarozerr
left a comment
serdarozerr
left a comment
There was a problem hiding this comment.
Looks good, added one minor comment
kathap
force-pushed
the
add-missing-functions-to-alioss
branch
from
ee2ea21 to
8d04198
Compare
stephanme
approved these changes
Dec 18, 2025
github-project-automation
bot
moved this from Pending Review | Discussion
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing operations: copy, delete-recursive, list, properties, ensure-bucket-exists.