Skip to content

Conversation

@jsievers
Copy link
Contributor

@jsievers jsievers commented Aug 2, 2017

this is useful if you have one monitoring stack per
CF deployment and you want to construct the same metric names
based on the deployment name (e.g. "cf" instead of ((system_domain)) ) .

this is useful if you have one monitoring stack per
CF deployment and you want to construct the same metric names
based on the deployment name (e.g. "cf" instead of ((system_domain)) ) .
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/149889322

The labels on this github issue will be updated when the story is started.

@cfdreddbot
Copy link

Hey jsievers!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@dsabeti dsabeti changed the base branch from master to develop August 10, 2017 22:40
@dsabeti
Copy link
Contributor

dsabeti commented Aug 10, 2017

Hey @jsievers. FYI I've updated the PR to be based on develop rather than master.

Also, this looks like a pretty useful ops-file, and it could potentially make sense to support this as a first-class feature of cf-deployment. How would you feel if (after review of the PR) we moved this ops-file out of the community section and into the main operations directory?

@staylor14 staylor14 merged commit e3a00f2 into cloudfoundry:develop Aug 10, 2017
@jsievers
Copy link
Contributor Author

sure, we are fine with moving it to the operations directory as officially supported.
I think it's useful as long as there is no support for wildcards in ops files, otherwise the change would be only one replace operation.

@jsievers jsievers deleted the change_metron_deployment branch August 14, 2017 14:35
@dsabeti
Copy link
Contributor

dsabeti commented Sep 30, 2017

Hey @jsievers, I wanted to give you an update about this, because some things have changed. We recently stopped setting the deployment name explicitly in the manifest, because the metron_agent will use the deployment name from bosh by default.

As a result, the way one now renames their metron_agent deployment tag is to rename their bosh deployment. There are a few good reasons to do this -- most importantly that bosh itself tags metrics with the deployment name, so using the same deployment name allows operators to see bosh and cf metrics side by side. However, I wanted to check in and see how this affects your workflow. Do you ever want your metron deployment name to differ from your bosh deployment name?

@jsievers
Copy link
Contributor Author

jsievers commented Oct 2, 2017

for our workflow, we always want the metron deployment name to be the same as the bosh deployment name, so the new behaviour is what we want.
Do we want to keep the ops file in case someone would want to change the metron agent name for whatever reason?

@dsabeti
Copy link
Contributor

dsabeti commented Oct 3, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants