-
Notifications
You must be signed in to change notification settings - Fork 311
Ops file for changing metron agent deployment #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ops file for changing metron agent deployment #194
Conversation
this is useful if you have one monitoring stack per CF deployment and you want to construct the same metric names based on the deployment name (e.g. "cf" instead of ((system_domain)) ) .
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/149889322 The labels on this github issue will be updated when the story is started. |
|
Hey jsievers! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Hey @jsievers. FYI I've updated the PR to be based on Also, this looks like a pretty useful ops-file, and it could potentially make sense to support this as a first-class feature of cf-deployment. How would you feel if (after review of the PR) we moved this ops-file out of the |
|
sure, we are fine with moving it to the operations directory as officially supported. |
|
Hey @jsievers, I wanted to give you an update about this, because some things have changed. We recently stopped setting the deployment name explicitly in the manifest, because the metron_agent will use the deployment name from bosh by default. As a result, the way one now renames their metron_agent deployment tag is to rename their bosh deployment. There are a few good reasons to do this -- most importantly that bosh itself tags metrics with the deployment name, so using the same deployment name allows operators to see bosh and cf metrics side by side. However, I wanted to check in and see how this affects your workflow. Do you ever want your metron deployment name to differ from your bosh deployment name? |
|
for our workflow, we always want the metron deployment name to be the same as the bosh deployment name, so the new behaviour is what we want. |
|
I don't think anyone would want their metron deployment to differ from the
bosh deployment name, so we'll probably remove it.
…On Mon, Oct 2, 2017 at 12:04 AM Jan Sievers ***@***.***> wrote:
for our workflow, we always want the metron deployment name to be the same
as the bosh deployment name, so the new behaviour is what we want.
Do we want to keep the ops file in case someone would want to change the
metron agent name for whatever reason?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#194 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA23hfO8uW1zO6A8PcyJv7SY5MGYLhbmks5soIsKgaJpZM4OrRtN>
.
|
this is useful if you have one monitoring stack per
CF deployment and you want to construct the same metric names
based on the deployment name (e.g. "cf" instead of ((system_domain)) ) .