feat: Add Dockerfile #81
Conversation
Dockerfile
Outdated
| RUN mkdir "/backup/backup" | ||
| RUN mkdir "/backup/metrics" | ||
|
|
||
| RUN pip install backup-github-org==1.0.4 |
There was a problem hiding this comment.
Do not hardcode version here. Use ARG instead:
ARG VERSION
RUN pip install backup-github-org==${VERSION}
Dockerfile
Outdated
| WORKDIR /backup | ||
|
|
||
| ENV ACCESS_TOKEN="" | ||
| ENV ORGANIZATION="" |
There was a problem hiding this comment.
Think about approach: image should contain only application, not environment. In other words image shouldn't contain any environments.
Your env variables are part of environment.
Dockerfile
Outdated
| apt-get install -y git | ||
|
|
||
| RUN mkdir "/backup/backup" | ||
| RUN mkdir "/backup/metrics" |
Dockerfile
Outdated
|
|
||
| RUN pip install backup-github-org==1.0.4 | ||
|
|
||
| ENTRYPOINT backup-github --all -t $ACCESS_TOKEN -o /backup/backup --metrics_path /backup/metrics/${ORGANIZATION}.prom $ORGANIZATION |
There was a problem hiding this comment.
In short: do not use entrypoint, use cmd. If you want to know more, google it - 'entrypoint vs cmd'.
If speak roughly - you don't need to care about how to run application inside container, you only need to pack it into image
Dockerfile
Outdated
| ENV ACCESS_TOKEN="" | ||
| ENV ORGANIZATION="" | ||
|
|
||
| RUN apt-get update && apt-get upgrade -y && \ |
There was a problem hiding this comment.
Clean up apt cache at the end of dockerfile
Dockerfile
Outdated
| ENV ACCESS_TOKEN="" | ||
| ENV ORGANIZATION="" | ||
|
|
||
| RUN apt-get update && apt-get upgrade -y && \ |
There was a problem hiding this comment.
Do not use upgrade, it's antipattern
Dockerfile
Outdated
| ENV ORGANIZATION="" | ||
|
|
||
| RUN apt-get update && apt-get upgrade -y && \ | ||
| apt-get install -y git |
Dockerfile
Outdated
|
|
||
| ENTRYPOINT backup-github --all -t $ACCESS_TOKEN -o /backup/backup --metrics_path /backup/metrics/${ORGANIZATION}.prom $ORGANIZATION | ||
|
|
||
| # Run command: docker run -rm -v .\backup:/backup/backup -v .\metrics:/backup/metrics -e ACCESS_TOKEN={} -e ORGANIZATION={} No newline at end of file |
There was a problem hiding this comment.
Finally your Dockerfile should look like this:
FROM python:3.10
WORKDIR /backup
ARG VERSION
ENV DEBIAN_FRONTEND=noninteractive
RUN mkdir /backup/{backup,metrics} \
&& pip install backup-github-org==${VERSION}
CMD ["backup-github", "--help"]
Fixes: #77