Skip to content

Conversation

@jpmelos
Copy link
Member

@jpmelos jpmelos commented Mar 24, 2021

Going to release 0.12 before merging #185 and #186.

@jpmelos jpmelos requested a review from thomasst March 24, 2021 11:54
@jpmelos jpmelos self-assigned this Mar 24, 2021
@jpmelos
Copy link
Member Author

jpmelos commented Mar 24, 2021

@thomasst any PRs you'd like to merge before we release 0.12? I see you have 3 PRs recently opened.

@thomasst
Copy link
Member

There is another fix I wanted to do today or tomorrow. I'll see if I can squeeze it in today.

@jpmelos
Copy link
Member Author

jpmelos commented Mar 24, 2021

No worries, I can wait.

@thomasst
Copy link
Member

FYI, this one is still pending a second review: #188

Copy link
Member

@thomasst thomasst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to release now. Can you amend the changelog?

@jpmelos jpmelos requested a review from thomasst March 25, 2021 14:11
Copy link
Member

@thomasst thomasst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In the future I would probably just refer to the shortened commit hash in each change log entry to avoid linking to GitHub-specific stuff. No big deal though.

@jpmelos jpmelos merged commit 97d7642 into master Mar 25, 2021
@jpmelos jpmelos deleted the release-0.12 branch March 25, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants