Ensure users can see v2 projects when viewing issues and PRs, avoid v1 projects on GHES 3.17 and newer

[andyfeller]

Fixes #10716, #10708, #11409

With v1 classic projects being deprecated, this pull request improves users' v2 projects experience while also ensuring v1 projects functionality works for the correct GHES versions:

• gh issue view will show information about v2 projects it is contained on
• gh pr view will show information about v2 projects it is contained on
• gh will avoid retrieving data or making v1 project API calls if GHES version is 3.17 or newer

Demo

GitHub.com

Source: Tiny Kanban (view)

Source: tinyfists/gh-nonsense#7

$ gh issue view https://github.com/tinyfists/gh-nonsense/issues/7
Working...
Demonstrate viewing issues on v2 projects tinyfists/gh-nonsense#7
Open • andyfeller opened about 6 months ago • 0 comments
Labels: documentation, enhancement
Projects: Tiny Kanban (In review)


  ## Circles                                                                                                          
                                                                                                                      
  │ I like circles                                                                                                    
  │ they're for me                                                                                                    
  │ because point A is point B                                                                                        


View this issue on GitHub: https://github.com/tinyfists/gh-nonsense/issues/7

Source: tinyfists/gh-nonsense#8

$ gh pr view https://github.com/tinyfists/gh-nonsense/pull/8
Working...
Script to create and delete discussion comment tinyfists/gh-nonsense#8
Open • andyfeller wants to merge 1 commit into main from v2-project-pr-demo • about 4 minutes ago
+109 -0 • No checks
Projects: Tiny Kanban (No Status)


  This is just a random example of a pull request contained on a v2 project.                                          


View this pull request on GitHub: https://github.com/tinyfists/gh-nonsense/pull/8

GHES 3.17

$ gh api /meta --hostname ghe.io
{
  "verifiable_password_authentication": false,
  "installed_version": "3.17.0"
}

$ gh issue view https://ghe.io/andyfeller/v1-repo-projects/issues/1
Working...
Seeing if GHES 3.17 blows up over v1 projects andyfeller/v1-repo-projects#1
Open • andyfeller opened about 20 days ago • 0 comments
Projects: v2 team planning (No Status)


  This is just a test of  gh issue create  experience on a feature branch to see how it handles the GHES version for  
  feature detection.                                                                                                  


View this issue on GitHub: https://ghe.io/andyfeller/v1-repo-projects/issues/1


$ gh pr view https://ghe.io/andyfeller/v1-repo-projects/pull/2
Working...
Create a simple example for demo andyfeller/v1-repo-projects#2
Open • andyfeller wants to merge 1 commit into main from v2-project-pr-demo • about 1 minute ago
+3 -0 • No checks
Projects: v2 team planning (In Progress)


  No description provided


View this pull request on GitHub: https://ghe.io/andyfeller/v1-repo-projects/pull/2

GHES 3.16

$ gh issue view https://andyfeller-04bfba7b049b250e8.ghe-test.net/v1-project-demo/projects/issues/3
Working...
I'm on BOTH v1 and v2 projects! v1-project-demo/projects#3
Open • ghe-admin opened about 4 minutes ago • 0 comments
Projects: v2 kanban (No Status), v1 classy (Awaiting triage)


  Such a lucky issue, not many of us today!                                                                           


View this issue on GitHub: https://andyfeller-04bfba7b049b250e8.ghe-test.net/v1-project-demo/projects/issues/3


$ gh pr view https://andyfeller-04bfba7b049b250e8.ghe-test.net/v1-project-demo/projects/pull/4
Working...
Demo of a PR on v1 and v2 projects v1-project-demo/projects#4
Open • ghe-admin wants to merge 1 commit into main from v1-v2-project-pr-demo • about 2 minutes ago
+3 -0 • No checks
Projects: v2 kanban (In review), v1 classy (In progress)


  Nothing really special, not like #3                                                                                 


View this pull request on GitHub: https://andyfeller-04bfba7b049b250e8.ghe-test.net/v1-project-demo/projects/pull/4

[Copilot]

Pull Request Overview

Enhances project support by displaying v2 projects in issue and PR views while properly handling v1 project deprecation for GHES 3.17+. This ensures users can see v2 project information and avoids v1 API calls on newer GHES versions.

• Adds v2 project item support to issue and PR view commands
• Updates feature detection to check GHES version for v1 project support cutoff at 3.17
• Modifies tests to properly mock v2 project data

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/cmd/pr/view/view.go	Adds projectItems field and v2 project display logic
pkg/cmd/pr/view/view_test.go	Updates test expectations to include v2 projects
pkg/cmd/pr/view/fixtures/prViewPreviewWithMetadataByNumber.json	Adds test fixture data for v2 projects
pkg/cmd/issue/view/view.go	Adds projectItems field and v2 project display logic
pkg/cmd/issue/view/view_test.go	Refactors tests to use mock functions for v2 project data
internal/featuredetection/feature_detection.go	Implements GHES version checking for v1 project support
internal/featuredetection/feature_detection_test.go	Adds comprehensive tests for version-based feature detection
api/queries_projects_v2.go	Adds TotalCount field to v2 project queries
api/queries_issue.go	Adds TotalCount field to ProjectItems struct

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[BagToad]

LGTM!

[omarshahen541-dotcom]

SECURITY