Better callback url base management (behind reverse proxy)#239
Open
nikiink wants to merge 2 commits intockan:masterfrom
Open
Better callback url base management (behind reverse proxy)#239nikiink wants to merge 2 commits intockan:masterfrom
nikiink wants to merge 2 commits intockan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
When behind reverse proxy datapusher try to reach ckan using the external url (ckan.site_url) instead of using ckan.datapusher.callback_url_base when configured. This fix read the original_url_base (the external url) sent from ckan and replace it with callback_url_base.
See ckan pull request ckan/ckan#6617