vdi-streaming: add lvm streaming support #168
Conversation
test_vgpu.sh
Outdated
| OPENSTACK_LOGS=${OPENSTACK_LOGS:-"/opt/stack/workspace/test_vgpu/logs"} | ||
| TMP_LOG_DIR=/tmp/openstack | ||
|
|
||
| VGPU_CREATE_SUCCESS_FLAG="VGPU_CREATE_SUCCESS" |
There was a problem hiding this comment.
Rather than these we should have a separate PASSED (and probably FAILED flag).
Is a different script grepping for the result? If so, then we can easily grep for FAILED.
Perhaps this script should be wrapped so we can treat any failure as FAILED (i.e. the test_vgpu.sh script has "set -ex" at the top, but the calling script will consider the script's exit code)
There was a problem hiding this comment.
Got it, will modify.
| echo "VGPU create success" | ||
| echo $VGPU_CREATE_SUCCESS_FLAG | ||
| echo "###################Check LVM image upload status#####################" | ||
| nova image-create --poll $VM_NAME $SNAPSHOT_NAME |
There was a problem hiding this comment.
Can we also retrieve the image please? Since the upload/download are creating VHDs on the fly, we need to check that the uploaded VHD is still valid. Best way is to create an new server from the image
There was a problem hiding this comment.
Will add another VM create based on the new image
naichuans
force-pushed
the
lvm_support
branch
2 times, most recently
from
eee8e2d to
55e7596
Compare
| vm_name = $1 | ||
| while : | ||
| do | ||
| echo "Waitting to VM active" |
test_vgpu.sh
Outdated
| rm $DEVSTACK_PATH -rf | ||
| git clone https://github.com/openstack-dev/devstack.git | ||
|
|
||
| sed -i '/iniset $NOVA_CONF DEFAULT flat_injected \"False\"/a\ iniset $NOVA_CONF xenserver image_handler "$vdi_remote_stream"' $DEVSTACK_PATH/lib/nova_plugins/hypervisor-xenserver |
There was a problem hiding this comment.
This is quite ugly... I thought there was a way to do this with hook scripts, or in the vGPU job config on Jenkins rather than in this script?
There was a problem hiding this comment.
Will check if we can do it.
| echo "[devices]" >> ${DEVSTACK_PATH}/local.conf | ||
| echo "enabled_vgpu_types = $first_vgpu_type" >> ${DEVSTACK_PATH}/local.conf | ||
| fi | ||
| echo "###################Set image handler to remote stream#####################" |
There was a problem hiding this comment.
If we're doing this here, why do we also need the line at 109?
There was a problem hiding this comment.
Sorry, forgot to remove it. It doesn't work when I modify local.conf.
naichuans
force-pushed
the
lvm_support
branch
4 times, most recently
from
bcabc35 to
1d82471
Compare
Add code to check vdi streaming on LVM
Add code to check vdi streaming on LVM