Skip to content

Conversation

@kanru
Copy link
Member

@kanru kanru commented Jul 18, 2025

@coveralls
Copy link

Coverage Status

coverage: 95.767%. remained the same
when pulling a87c583 on push-rxxzmwykyysy
into 806842c on master.

@kanru kanru merged commit e41fcd8 into master Jul 18, 2025
3 checks passed
@yan12125
Copy link
Collaborator

How about cmake_minimum_required(VERSION 3.5)? With that change, chewing-editor builds fine with CMake 4.0.3 on Arch Linux.

@kanru
Copy link
Member Author

kanru commented Jul 20, 2025

How about cmake_minimum_required(VERSION 3.5)? With that change, chewing-editor builds fine with CMake 4.0.3 on Arch Linux.

I think setting a upper bound as latest tested version is recommended so it doesn't break if CMake was upgraded.

@yan12125
Copy link
Collaborator

Sorry, I misunderstood cmake_minimum_required and thought setting an upper bound prevents running on even newer cmake. This change indeed makes sense, thank you!

@kanru kanru deleted the push-rxxzmwykyysy branch July 26, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants