Implement Wallet.create_pay_to_contract_address#22
Merged
Conversation
Pull Request Test Coverage Report for Build 10088223499Details
💛 - Coveralls |
Yamaguchi
commented
Jul 21, 2024
crates/wallet/Cargo.toml
Outdated
| serde_json = { version = "^1.0" } | ||
| tdk_chain = { path = "../chain", version = "0.15.0", features = ["miniscript", "serde"], default-features = false } | ||
| tdk_persist = { path = "../persist", version = "0.3.0", features = ["miniscript", "serde"], default-features = false } | ||
| curv-kzen = { git = "https://github.com/Yamaguchi/curv", branch = "make_GE_public_interface_for_sec256k1" } |
Contributor
Author
There was a problem hiding this comment.
curvのライブラリに一部問題があるため、forkしたものを使用しています。
fork元のリポジトリにPRは投げています。
ZenGo-X/curv#185
Yamaguchi
commented
Jul 22, 2024
| #[cfg(feature = "std")] | ||
| impl std::error::Error for ApplyBlockError {} | ||
|
|
||
| const CONTRACT_MAX_SIZE: usize = 256; |
Contributor
Author
There was a problem hiding this comment.
Contractの最大バイト数を暫定で256としています。(アプリ側でチェックするのであれば、ここでは不要かもしれません)
Yamaguchi
force-pushed
the
generate_p2c_address
branch
from
a79927a to
0b7e651
Compare
Contributor
Author
|
curvをやめて、secp256k1のメソッドを使用するように変更してます。 |
Yamaguchi
force-pushed
the
generate_p2c_address
branch
3 times, most recently
from
9fbe7ef to
d1e714b
Compare
rantan
requested changes
Jul 23, 2024
Yamaguchi
force-pushed
the
generate_p2c_address
branch
from
00c7faf to
4ceda75
Compare
* Remove unused line * Validate in Wallet::pay_to_contract_key * Modify the value to ensure that the value given during initialisation of the Scalar does not exceed Scalar::MAX.
Yamaguchi
force-pushed
the
generate_p2c_address
branch
from
4ceda75 to
3f748d8
Compare
Yamaguchi
force-pushed
the
generate_p2c_address
branch
from
9bede4c to
da7cde1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements to generate Pay-To-Contract address.
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: