Conversation
b4f7a64 to
1ffb606
Compare
1ffb606 to
a2f271b
Compare
Karrq
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DRR (Deficit Round Robin) has a fundamental head-of-line blocking interaction with netem that causes high-delay destinations to block low-delay destinations.
DRR's dequeue() peeks at the first active class. Netem (a non-work-conserving qdisc) returns NULL when the configured delay hasn't elapsed yet. DRR sees NULL and immediately returns without trying other classes. This is a kernel-level issue with no userspace workaround.
Proposed change
Replaced DRR with HTB as the root classful qdisc. HTB's dequeue() correctly handles non-work-conserving children: when a child returns NULL, it advances to the next class instead of giving up.