Inhibit management of share config.php file when mpf_disable_mission_portal_docroot_sync_from_share_gui is defined #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portal_docroot_sync_from_share_gui is defined In preparation for possibly removing the share/GUI folder entirely. Ticket: ENT-12658 Changelog: title
aleksandrychev
approved these changes
Feb 12, 2025
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md Ticket: none Changelog: none (cherry picked from commit c219971)
Contributor
Author
|
blocked by cfengine/cf-remote#124, that bug is what is breaking acceptance_tests |
Contributor
Author
|
@cf-bottom jenkins please, thanks. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11733/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11733/ |
larsewi
approved these changes
Feb 20, 2025
nickanderson
approved these changes
Feb 20, 2025
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Looks good to me. Just a note about packaging stuff unrelated to the policy itself.
craigcomstock
added a commit
to craigcomstock/buildscripts
that referenced
this pull request
Feb 20, 2025
Related to inhibiting management of share config.php file when a class is defined. cfengine/masterfiles#2987 Ticket: ENT-12658 Changelog: none
craigcomstock
added
the
cherry-pick?
craigcomstock
added a commit
to craigcomstock/buildscripts
that referenced
this pull request
Aug 19, 2025
Related to inhibiting management of share config.php file when a class is defined. cfengine/masterfiles#2987 Ticket: ENT-12658 Changelog: none
craigcomstock
added a commit
to craigcomstock/buildscripts
that referenced
this pull request
Aug 20, 2025
… packages To change the port, masterfiles can change these files which are distributed as part of the package so we must mark them as configuration files. cfengine/masterfiles#2987 Ticket: ENT-12658 Changelog: none
craigcomstock
added a commit
to craigcomstock/buildscripts
that referenced
this pull request
Aug 27, 2025
… packages To change the port, masterfiles can change these files which are distributed as part of the package so we must mark them as configuration files. cfengine/masterfiles#2987 Ticket: ENT-12658 Changelog: none (cherry picked from commit 46ba411)
craigcomstock
added a commit
to craigcomstock/buildscripts
that referenced
this pull request
Aug 27, 2025
… packages To change the port, masterfiles can change these files which are distributed as part of the package so we must mark them as configuration files. cfengine/masterfiles#2987 Ticket: ENT-12658 Changelog: none (cherry picked from commit 46ba411)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for possibly removing the share/GUI folder entirely.
Ticket: ENT-12658
Changelog: title