Skip to content

Conversation

@larsewi
Copy link
Contributor

@larsewi larsewi commented Aug 5, 2025

  • classfilterdata() now supports object of objects and object of arrays

Depends on NorthernTechHQ/libntech#254

@larsewi larsewi force-pushed the classfilterdata-i2 branch from 0e7d1e7 to d96b4fe Compare August 5, 2025 14:35
@larsewi larsewi force-pushed the classfilterdata-i2 branch 4 times, most recently from 74876c4 to e73693f Compare August 5, 2025 15:51
@larsewi larsewi marked this pull request as ready for review August 5, 2025 21:02
@larsewi larsewi force-pushed the classfilterdata-i2 branch 2 times, most recently from 96a4953 to b7a2d8d Compare August 6, 2025 09:30
@larsewi
Copy link
Contributor Author

larsewi commented Aug 6, 2025

@cf-bottom Jenkins please :)

@larsewi larsewi force-pushed the classfilterdata-i2 branch 2 times, most recently from 9819c78 to 1ef4707 Compare August 6, 2025 11:08
@cfengine cfengine deleted a comment from cf-bottom Aug 6, 2025
@cf-bottom
Copy link

larsewi added a commit to larsewi/documentation that referenced this pull request Aug 11, 2025
…/objects"

This commit broke docs because it depends on
cfengine/core#5850. Once the dependency is
merged, it should be safe to reapply this commit.

This reverts commit 3bc6348.

Ticket: CFE-4562
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi requested review from jakub-nt and victormlg August 12, 2025 10:55
Copy link
Contributor

@victormlg victormlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I would generally suggest replacing exogenous and the other term with more plain language that will be easier for maintenance programmers to handle.

@larsewi larsewi force-pushed the classfilterdata-i2 branch 3 times, most recently from 55c5267 to 5f2a78a Compare August 14, 2025 15:56
@larsewi
Copy link
Contributor Author

larsewi commented Aug 14, 2025

@cf-bottom Jenkins please :)

craigcomstock
craigcomstock previously approved these changes Aug 14, 2025
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@larsewi larsewi force-pushed the classfilterdata-i2 branch from 5f2a78a to 80f1e84 Compare August 14, 2025 16:05
@cfengine cfengine deleted a comment from cf-bottom Aug 14, 2025
@larsewi larsewi force-pushed the classfilterdata-i2 branch from 80f1e84 to d980a80 Compare August 14, 2025 16:20
@cfengine cfengine deleted a comment from cf-bottom Aug 14, 2025
@cf-bottom
Copy link

The class expression can be stored in either the key to the object
itself, or key/index inside object.

Ticket: CFE-4562
Changelog: Commit
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi larsewi force-pushed the classfilterdata-i2 branch from d980a80 to d91b294 Compare August 19, 2025 11:27
@larsewi larsewi merged commit c6f9666 into cfengine:master Aug 19, 2025
12 checks passed
@larsewi larsewi deleted the classfilterdata-i2 branch October 2, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants