-
Notifications
You must be signed in to change notification settings - Fork 197
CFE-4562: classfilterdata(): added support of object of arrays and object of objects #5850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e7d1e7 to
d96b4fe
Compare
74876c4 to
e73693f
Compare
96a4953 to
b7a2d8d
Compare
|
@cf-bottom Jenkins please :) |
9819c78 to
1ef4707
Compare
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12453/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12453/ |
…/objects" This commit broke docs because it depends on cfengine/core#5850. Once the dependency is merged, it should be safe to reapply this commit. This reverts commit 3bc6348. Ticket: CFE-4562 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
victormlg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
craigcomstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I would generally suggest replacing exogenous and the other term with more plain language that will be easier for maintenance programmers to handle.
tests/acceptance/01_vars/02_functions/classfilterdata_object_of_objects_endogenous.cf
Outdated
Show resolved
Hide resolved
55c5267 to
5f2a78a
Compare
|
@cf-bottom Jenkins please :) |
craigcomstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
5f2a78a to
80f1e84
Compare
80f1e84 to
d980a80
Compare
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12496/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12496/ |
The class expression can be stored in either the key to the object itself, or key/index inside object. Ticket: CFE-4562 Changelog: Commit Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
d980a80 to
d91b294
Compare
Depends on NorthernTechHQ/libntech#254