Added checksum checking when downloading packages #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
reviewed
Dec 12, 2024
cf_remote/web.py
Outdated
Comment on lines
28
to
31
| def download_package(url, path=None, checksum=None): | ||
|
|
||
| if not checksum : | ||
| user_error("No checksum found") |
Member
There was a problem hiding this comment.
Please make checksum not an optional parameter.
olehermanse
reviewed
Dec 12, 2024
cf_remote/web.py
Outdated
|
|
||
|
|
||
| if checksum and not SHA256_RE.match(checksum): | ||
| user_error("Invalid checksum or unsupOkported checksum algorithm: '%s'" % checksum) |
Member
There was a problem hiding this comment.
Suggested change
| user_error("Invalid checksum or unsupOkported checksum algorithm: '%s'" % checksum) | |
| user_error("Invalid checksum or unsupported checksum algorithm: '%s'" % checksum) |
olehermanse
reviewed
Dec 12, 2024
cf_remote/web.py
Outdated
|
|
||
| answer = urllib.request.urlopen(url).read() | ||
|
|
||
| if checksum : |
Member
There was a problem hiding this comment.
Suggested change
| if checksum : | |
| if checksum: |
olehermanse
reviewed
Dec 12, 2024
cf_remote/web.py
Outdated
| if checksum : | ||
| digest = hashlib.sha256(answer).digest().hex() | ||
| if checksum != digest : | ||
| user_error("Mismatching checksums") |
Member
There was a problem hiding this comment.
Suggested change
| user_error("Mismatching checksums") | |
| user_error("Downloaded file '{}' does not match expected checksum '{}'".format(filename, checksum) |
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
download-package-checksum
branch
from
da1eaed to
2c726e3
Compare
olehermanse
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.