Fix path issue on windows, when mix "/" and "\" with css-loader#20
Open
systembugtj wants to merge 2 commits intocesarandreu:masterfrom
Open
Fix path issue on windows, when mix "/" and "\" with css-loader#20systembugtj wants to merge 2 commits intocesarandreu:masterfrom
systembugtj wants to merge 2 commits intocesarandreu:masterfrom
Conversation
__dirname + "/app" won't work well on windows. use path.join to make sure the path friendly with window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__dirname + "/app" won't work well on windows when deal with css-loader, may be css-loader issue. use path.join to let the path friendly on window. It should also work on Mac or linux.
Some related error from windows
ERROR in ./app/styles.css
Module parse failed: D:\tests\react-web-app\app\styles.css Line 1: Unexpected token :
You may need an appropriate loader to handle this file type.
| :global *,
| :global *:after,
| :global *:before {
@ ./app/index.js 11:17-40
ERROR in ./~/normalize.css/normalize.css
Module parse failed: D:\tests\react-web-app\node_modules\normalize.css\normalize.css Line 9: Unexpected token {
You may need an appropriate loader to handle this file type.
| /
|
| html {
| font-family: sans-serif; / 1 /
| -ms-text-size-adjust: 100%; / 2 */
@ ./app/index.js 9:0-24
ERROR in ./app/components/Hello/Hello.css
Module parse failed: D:\tests\react-web-app\app\components\Hello\Hello.css Line 1: Unexpected token .
You may need an appropriate loader to handle this file type.
| .greeting {
| color: #00F;
| }
@ ./app/components/Hello/Hello.js 29:16-38