Skip to content

Conversation

@hieronx
Copy link
Contributor

@hieronx hieronx commented Sep 11, 2025

No description provided.

@hieronx hieronx changed the title Idea; fixed rate price manager Idea: fixed rate price manager Sep 12, 2025
@github-actions
Copy link

Coverage after merging fixed-rate-accrual into main will be

95.94%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/adapters
   AxelarAdapter.sol100%100%100%100%
   LayerZeroAdapter.sol87.50%100%80%86.84%81–83, 87–88
   WormholeAdapter.sol100%100%100%100%
src/common
   GasService.sol97.06%100%100%96.88%112, 120
   Gateway.sol100%100%100%100%
   Guardian.sol88.57%64.29%100%92.68%128, 128–129, 48–52
   MessageDispatcher.sol96.26%90.32%100%98.40%541–542, 66–71
   MessageProcessor.sol95.21%90.32%100%97.98%206, 54–59, 73
   MultiAdapter.sol98.51%100%93.75%98.88%211
   PoolEscrow.sol100%100%100%100%
   Root.sol100%100%100%100%
   TokenRecoverer.sol100%100%100%100%
src/common/factories
   PoolEscrowFactory.sol100%100%100%100%
src/common/libraries
   MessageLib.sol100%100%100%100%
   PricingLib.sol100%100%100%100%
   RequestCallbackMessageLib.sol89.58%50%100%100%106, 141, 38, 57, 77
   RequestMessageLib.sol89.74%50%100%100%37, 55, 72, 89
src/hooks
   BaseTransferHook.sol100%100%100%100%
   FreelyTransferable.sol100%100%100%100%
   FreezeOnly.sol100%100%100%100%
   FullRestrictions.sol100%100%100%100%
   RedemptionRestrictions.sol100%100%100%100%
src/hooks/libraries
   UpdateRestrictionMessageLib.sol90%50%100%100%40, 61, 82
src/hub
   Accounting.sol93.75%96%100%91.53%114–115, 118–119, 134, 137
   Holdings.sol97.44%88%100%100%116, 221, 82
   Hub.sol86.50%46.67%100%91.23%114, 429–430, 433, 433–434, 452, 455, 455–456, 476, 493, 510, 537, 541, 571–572, 572, 572–573, 573, 573, 578, 583, 601, 611, 621, 621, 621, 623, 637, 647–649, 769, 84–85, 85–86, 86–87, 87–89
   HubHelpers.sol88.46%87.50%90%88.54%155–157, 163–165, 215, 239, 244–247, 54–55
   HubRegistry.sol93.67%79.17%100%100%104, 110, 116, 33, 44
   ShareClassManager.sol100%100%100%100%
src/managers
   FixedRatePriceManager.sol0%0%0%0%30, 33–34, 36–37, 39–40, 42, 50–51, 58–59, 59, 59–60, 60, 60, 62, 62, 62, 64–67, 69–71, 73–74, 77
   MerkleProofManager.sol79.45%61.11%88.89%84.78%104, 111, 130–131, 131, 131, 133–134, 136–137, 40–41, 44, 54
   OnOfframpManager.sol100%100%100%100%
src/managers/decoders
   BaseDecoder.sol75%100%75%75%43–44
   CircleDecoder.sol0%100%0%0%11, 16, 20, 22
   VaultDecoder.sol0%100%0%0%10, 104, 110, 15–16, 22, 28, 34, 40, 46, 52, 58, 64, 69, 75, 80, 86, 9, 92, 98
src/misc
   Auth.sol100%100%100%100%
   ERC20.sol100%100%100%100%
   Escrow.sol56.25%33.33%100%66.67%15, 17, 21–22, 22, 22, 24
   Multicall.sol83.33%33.33%100%100%17, 17
   Recoverable.sol100%100%100%100%
   ReentrancyProtection.sol90%75%100%100%22
src/misc/libraries
   ArrayLib.sol100%100%100%100%
   BitmapLib.sol100%100%100%100%
   BytesLib.sol90.09%54.17%100%100%109, 120, 131, 14, 142, 153, 16, 164, 175, 186, 87
   CastLib.sol95.24%66.67%100%100%10, 34
   EIP712Lib.sol100%100%100%100%
   MathLib.sol93.40%76.19%100%97.30%35–36, 45, 47, 49, 51, 53
   MerkleProofLib.sol100%100%100%100%
   SafeTransferLib.sol96.97%92.86%100%100%75
   SignatureLib.sol95.24%80%100%100%17
   StringLib.sol100%100%100%100%
   TransientArrayLib.sol100%100%100%100%
   TransientBytesLib.sol100%100%100%100%
   TransientStorageLib.sol100%100%100%100%
src/spoke
   BalanceSheet.sol99.46%96.77%100%100%59
   ContractUpdater.sol100%100%100%100%
   ShareToken.sol93.59%66.67%94.44%98.04%101, 113, 146, 33
   Spoke.sol95.21%85.57%100%98.64%102, 102–103, 103, 128, 128–129, 129, 131, 325, 331–333, 387–388, 413–414
src/spoke/factories
   TokenFactory.sol92%50%100%94.74%24–25
src/spoke/libraries
   UpdateContractMessageLib.sol89.74%50%100%100%110, 40, 62, 86
src/valuations
   IdentityValuation.sol100%100%100%100%
   OracleValuation.sol100%100%100%100%
src/vaults
   AsyncRequestManager.sol95.03%85.71%93.02%98.35%164, 167, 170, 173, 184, 196, 201, 220, 227, 260, 294, 408, 413, 452, 454
   AsyncVault.sol96.25%83.33%95%98.15%148, 49
   BaseVaults.sol92.50%80.77%95.24%93.94%125, 138, 240, 313–314, 400–401, 86–87, 87, 87–89
   SyncDepositVault.sol100%100%100%100%
   SyncManager.sol83.19%70%87.50%85.71%106–107, 109, 161, 181–182, 227–228, 59–61, 63, 63, 63, 65, 70, 75
   VaultRouter.sol91.16%53.85%100%98.97%105, 108–109, 122, 122–123, 123, 138–139, 158, 158, 175, 221
src/vaults/factories
   AsyncVaultFactory.sol89.47%50%100%93.33%36, 48
   SyncDepositVaultFactory.sol91.30%50%100%94.74%45, 60

@sherlock-ai-github-agent
Copy link

PR Summary

Since the provided summaries contain only object references without any actual diff content, I'm unable to generate a meaningful summary of the changes in the Pull Request.

To provide a proper summary, I would need:

  1. The actual diff content showing code changes
  2. File paths that were modified
  3. Specific additions/removals/changes made

Please provide the concrete diff information or file changes that these summary objects reference, and I'll be happy to generate a clear and useful summary of the PR changes.

@sherlock-ai-github-agent
Copy link

Sherlock AI Findings

The automated tool identified the following potential security issues in the codebase. Please review the details for each issue in the linked dashboard.

# Title Severity Details
1 Division-by-zero in updates computation when period is zero Medium View Details

Next Steps: Review the linked issues in the dashboard and address high-severity bugs first. Contact the team if you need assistance.

Full report available at: https://ai.sherlock.xyz/runs/76dae1d3-6803-4be9-b9b3-02bfe5e0e870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants