Skip to content

Conversation

@Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 6, 2026

Updating the template for netlify.toml with the most important change being the upgrade to Node 24. Current Cedar versions no longer work with Node 20

@github-actions github-actions bot added this to the next-release-patch milestone Jan 6, 2026
@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit d5a1cab
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/695e19dfa28c3800081fcb70

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 6, 2026

Greptile Summary

Updated the Netlify deployment template to use Node 24, aligning with Cedar's current Node version requirements (project templates already specify node=24.x).

  • Upgraded NODE_VERSION from 20 to 24 in the build environment configuration
  • Updated documentation links to current Netlify CLI documentation URLs
  • Improved comment formatting for better readability

The change is necessary because current Cedar versions no longer work with Node 20.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is straightforward and necessary - updating a template file to specify Node 24 instead of 20. This aligns with the project's existing Node version requirements seen in package.json templates. The only additional changes are documentation link updates and comment formatting improvements, which carry no risk.
  • No files require special attention

Important Files Changed

Filename Overview
packages/cli/src/commands/setup/deploy/templates/netlify.js Updated Node version from 20 to 24 and improved documentation links

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CLI as Cedar CLI
    participant Template as netlify.js Template
    participant Netlify as Netlify Platform

    Dev->>CLI: Run setup deploy command
    CLI->>Template: Load Netlify config template
    Template->>Template: Generate netlify.toml with Node 24
    Template->>CLI: Return config string
    CLI->>Dev: Create netlify.toml file
    Dev->>Netlify: Deploy with netlify.toml
    Netlify->>Netlify: Use NODE_VERSION=24 from config
    Netlify->>Netlify: Build with yarn cedar deploy netlify
    Netlify->>Dev: Deployment complete
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented Jan 6, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit d5a1cab

Command Status Duration Result
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 6s View ↗
nx run-many -t build ✅ Succeeded 6s View ↗
nx run-many -t test --minWorkers=1 --maxWorkers=4 ✅ Succeeded 1m 32s View ↗
nx run-many -t test:types ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-07 08:55:48 UTC

@nx-cloud
Copy link

nx-cloud bot commented Jan 6, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 4e58e44

Command Status Duration Result
nx run-many -t test --minWorkers=1 --maxWorkers=4 ❌ Failed 1m 13s View ↗
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 5s View ↗
nx run-many -t build ✅ Succeeded 3m 26s View ↗
nx run-many -t test:types ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-06 23:49:21 UTC

@Tobbe Tobbe merged commit 688353f into main Jan 7, 2026
41 checks passed
@Tobbe Tobbe deleted the tobbe-netlify-node-24 branch January 7, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants