forked from OpenMS/OpenMS
-
Notifications
You must be signed in to change notification settings - Fork 5
Colorizer+ConsoleUtils Classes Version 1 (new) - Color the commandline #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mariogrenadine
wants to merge
33
commits into
cbielow:develop
Choose a base branch
from
mariogrenadine:consoleutils_testclass
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Colorizer+ConsoleUtils Classes Version 1 (new) - Color the commandline #134
mariogrenadine
wants to merge
33
commits into
cbielow:develop
from
mariogrenadine:consoleutils_testclass
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int for further test cases
…. There's a problem that now the colorizer testclass doesn't work as is should, working around this
…still needed like cerr/cout recognition, CU testclass finalization
… subclass = no colorisation.
…ut_ variable being accessible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Colorizer+ConsoleUtils Classes Version 1 (new)
encapsulated Colorizer methods
updated Colorizer class to differentiate outputs between filer/prompt for Unix based systems. ANSI codes won't be fed into
files through Colorizer instances.
Due to this functionality Colorizer_test had to be rewritten. The test file run automatically suppresses commandline outputs therefore Colorizer instances for Unix based systems don't colorize the text and their full functionality could not be tested
directly. As a partial solution to this a separate subclass ColorizerTester of Colorizer was created that implements original coloring functinality of Colorizer but for stringstreams instead or cout/cerr streams for the commandline. In this way,
the coloring functionality can be tested, however should Colorizer methods be ever changed, the ColorizerTester methods should be changed accordingly in order for the tests to be accurate. Commandline output supression also limits testing of Colorizer instances.
updated ConsoleUtils and Consoleutils_test - added encapsulated Colorizer methods, added a new BreakString function
updated ConsoleUtils_test to match new functionality of ConsoleUtils class
Checklist
How can I get additional information on failed tests during CI
Click to expand
If your PR is failing you can check outIf you click in the column that lists the failed tests you will get detailed error messages.
Advanced commands (admins / reviewer only)
Click to expand
/reformat(experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.rebuild jenkinswill retrigger Jenkins-based CI builds