fix: allow converting envs from value to valueFrom#643
Merged
Conversation
patrickpichler
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When kvisor is installed to read the cluster id from a configmap:
The value is exposed as an environment variable using
valueFrom:If we now want to read the cluster id directly from a string we can do:
However this will fail because Helm can't apply
valueFrom->valueorvalue->valueFromsince the three-way merge keeps the existing setting and adds the new one, which is invalid (can't have bothvalueandvalueFromdefined):The fix is doing the same as in castai/helm-charts#1092