Open
Conversation
987cb0d to
bc4d80a
Compare
bc4d80a to
f5fb2de
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the node to align with rollups-contracts v2.2.0, and refactors the claimer’s on-chain event lookup to avoid relying on chunked log filtering by using counter-based transition search instead.
Changes:
- Bump
ROLLUPS_CONTRACTS_VERSIONto2.2.0(and update SHA/env addresses). - Regenerate/update the
IConsensusGo binding to includegetNumberOfSubmittedClaims(). - Refactor
internal/claimer/blockchain.goto findClaimSubmitted/ClaimAcceptedevents viaethutil.FindTransitions+ per-block filtering.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
pkg/contracts/iconsensus/iconsensus.go |
Extends the generated binding ABI/methods to support GetNumberOfSubmittedClaims. |
internal/claimer/blockchain.go |
Replaces chunked log scanning with transition-based discovery + per-block event filtering. |
Makefile |
Updates contracts version/SHA and printed env addresses for the new contracts release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6340ea9 to
c249287
Compare
c249287 to
32ecf30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: depends on contracts release.
Additional dependencies on
ChunkedFilterLogs: