Open
Conversation
mpolitzer
force-pushed
the
feature/add-jsonrpc-prt-tests
branch
from
5b26aa7 to
875aa23
Compare
vfusco
requested review from
Copilot
and removed request for
renatomaia and
vfusco
There was a problem hiding this comment.
Pull request overview
This PR expands JSON-RPC test coverage for tournament-related (“prt”) methods and adjusts repository/query behavior to make list endpoints deterministic and align empty-list responses with existing “Application not found” semantics.
Changes:
- Add extensive JSON-RPC tests for tournament/commitment/match/match-advanced endpoints.
- Make list endpoints return
RESOURCE_NOT_FOUND: Application not foundwhen the result is empty and the application does not exist. - Stabilize ordering for pagination in Postgres queries (commitments and match advances).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/repository/postgres/match_advanced.go | Changes ordering for ListMatchAdvances to sort by OtherParent (stabilizes pagination within a fixed epoch/tournament/id_hash). |
| internal/repository/postgres/commitment.go | Adds secondary ORDER BY on Commitment to make pagination deterministic when many rows share the same EpochIndex. |
| internal/jsonrpc/jsonrpc.go | Adds “application exists” checks for multiple list handlers; tweaks GetMatchAdvanced parent handling. |
| internal/jsonrpc/util_test.go | Adds helper result structs for JSON unmarshalling in tests. |
| internal/jsonrpc/jsonrpc_test.go | Adds large suite of tests for new/expanded tournament data methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpolitzer
force-pushed
the
feature/add-jsonrpc-prt-tests
branch
2 times, most recently
from
5442605 to
e0b5bff
Compare
This was
linked to
issues
Feb 12, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpolitzer
force-pushed
the
feature/add-jsonrpc-prt-tests
branch
2 times, most recently
from
a13fa56 to
290a589
Compare
mpolitzer
force-pushed
the
feature/add-jsonrpc-prt-tests
branch
from
290a589 to
fc5f9a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #682