Skip to content

Conversation

@IanCal
Copy link
Contributor

@IanCal IanCal commented Jan 7, 2026

There are a few things slowing down the realm server tests:

  • Base realm starting when we don't use it
  • Starting too many prerender pages
  • Re-indexing the same contents multiple times
  • Not reusing the same realm server for read-only operations (before vs beforeEach use)
  • Indexing way more than we need

@IanCal IanCal marked this pull request as draft January 7, 2026 17:30
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7142d13e69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 15 to +17
module(
'Realm-specific Endpoints: can make request to post /_atomic',
function (hooks) {
function () {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore base realm server for base module resolution

This suite now only spins up the permissioned test realm, but the fixtures in this file still import https://cardstack.com/base/* (e.g., the place.gts payload below). With setupBaseRealmServer removed, createVirtualNetwork continues to map the base realm to http://localhost:4201/, so CachingDefinitionLookup will probe that URL and fail when resolving those base modules, leading to FilterRefersToNonexistentTypeError/fetch failures during indexing or rendering. Unless base realm modules are shimmed some other way, these tests will now break without a base realm server.

Useful? React with 👍 / 👎.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Host Test Results

    1 files  ±  0      1 suites  ±0   1h 37m 37s ⏱️ + 4m 18s
1 862 tests +211  1 846 ✅ +212  15 💤 ±0  0 ❌  - 1  1 🔥 ±0 
1 877 runs  +212  1 860 ✅ +213  15 💤 ±0  1 ❌  - 1  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit 9b5ba90. ± Comparison against base commit c0eb977.

This pull request removes 1 and adds 212 tests. Note that renamed tests count towards both.
Chrome ‑ Global error: Uncaught TypeError: Failed to fetch at http://localhost:7357/assets/chunk.960127ff7fdd4dd67122.js, line 153748  While executing test: Integration | card-copy: can copy multiple cards 
Chrome ‑ Acceptance | prerender | file-extract: falls back and marks mismatch when the extractor signals a content mismatch
Chrome ‑ Acceptance | prerender | file-extract: falls back when the FileDef module is missing extractAttributes
Chrome ‑ Acceptance | prerender | file-extract: returns an error when fileExtract is not enabled
Chrome ‑ Acceptance | prerender | file-extract: returns an error when the file fetch fails
Chrome ‑ Acceptance | prerender | file-extract: returns an error when the render model is missing
Chrome ‑ Acceptance | prerender | file-extract: uses the provided FileDef to extract attributes
Chrome ‑ Integration | Store: added instance that was previously not saved will begin to auto save after being added
Chrome ‑ Integration | Store: an instance can be restored after a loader reset
Chrome ‑ Integration | Store: an instance can debounce auto saves
Chrome ‑ Integration | Store: an instance can live update thru an error state
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants