-
Notifications
You must be signed in to change notification settings - Fork 12
Speed up realm server tests #3808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7142d13e69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| module( | ||
| 'Realm-specific Endpoints: can make request to post /_atomic', | ||
| function (hooks) { | ||
| function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore base realm server for base module resolution
This suite now only spins up the permissioned test realm, but the fixtures in this file still import https://cardstack.com/base/* (e.g., the place.gts payload below). With setupBaseRealmServer removed, createVirtualNetwork continues to map the base realm to http://localhost:4201/, so CachingDefinitionLookup will probe that URL and fail when resolving those base modules, leading to FilterRefersToNonexistentTypeError/fetch failures during indexing or rendering. Unless base realm modules are shimmed some other way, these tests will now break without a base realm server.
Useful? React with 👍 / 👎.
Host Test Results 1 files ± 0 1 suites ±0 1h 37m 37s ⏱️ + 4m 18s For more details on these errors, see this check. Results for commit 9b5ba90. ± Comparison against base commit c0eb977. This pull request removes 1 and adds 212 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There are a few things slowing down the realm server tests: