This repository was archived by the owner on Aug 16, 2023. It is now read-only.
SimpleAuthGoogleWebProvider.m: do not crash if account fields are not… #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… present in response
objectForKey (which is what the assignment does below) cannot handle null values.
While testing my profile came back as the following:
info = {
email = "jbicket@samsara.com";
"first_name" = John;
image = "https://lh5.googleusercontent.com/-hTUulT9CemI/AAAAAAAAAAI/AAAAAAAAABs/o6pMlpQ0Lvk/photo.jpg";
"last_name" = Bicket;
name = "John Bicket";
verified = 1;
};
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this and got a crash when I logged in for the first time. Google did not populate all the values, and objectForKey (which is what the assignment does below) cannot handle null values so the library would crash.
My profile came back as:
info = {
email = "jbicket@samsara.com";
"first_name" = John;
image = "https://lh5.googleusercontent.com/-hTUulT9CemI/AAAAAAAAAAI/AAAAAAAAABs/o6pMlpQ0Lvk/photo.jpg";
"last_name" = Bicket;
name = "John Bicket";
verified = 1;
};