Skip to content

fix output_value not referencing correct key#27

Open
senorsmile wants to merge 1 commit intoc-kr:masterfrom
senorsmile:output_value_fix
Open

fix output_value not referencing correct key#27
senorsmile wants to merge 1 commit intoc-kr:masterfrom
senorsmile:output_value_fix

Conversation

@senorsmile
Copy link

This patch fixes the output_value var referencing, which would produce an error like

Use of uninitialized value $output_​value in concatenation (.​) or string at 
/usr/lib/nagios/plugins/check_​json.​pl line 251.

The output_value var was attempting to reference a key like:

$json_response->{$key}
where
$key = "{foo}"

However, that would interpolate as:
$json_repsonse->{"{foo}"}
which obviously doesn't work.

@senorsmile
Copy link
Author

fixes (at least partially) #23

$label =~ s/[^a-zA-Z0-9_-]//g;
my $output_value;
$output_value = $json_response->{$key};
$output_value = $json_response->{$label};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this return $label just when it exists on the root of the json ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants